lanitochka17 commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.53-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

In an account with "Focus" mode enabled, change the mode to "Most Recent"
Log out of the account
Log in again to the same account
Verify if the "Focus Mode" popup is displayed
Verify if the popup can be closed by tapping outside of it

Expected Result:

The user should be able to close the "Focus Mode" popup by tapping on the screen outside of it

Actual Result:

When the "Focus" popup is displayed, the user can´t close it by tapping on the screen outside the popup

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/ee5f81b6-539c-46a2-9db1-5e1d34990897

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021851098193336540822
Upwork Job ID: 1851098193336540822
Last Price Increase: 2024-10-29
Automatic offers:

situchan | Reviewer | 104668615
ChavdaSachin | Contributor | 104668616

Issue Owner

Current Issue Owner: @VictoriaExpensify

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 1 month ago

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

neonbhai commented 1 month ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb - Inbox - The "Focus" popup can´t be closed by tapping outside of it

What is the root cause of that problem?

We don't handle the backdrop press in FocusModeNotification.tsx

What changes do you think we should make in order to solve the problem?

We will add the onBackdropPress prop to FocusModeNotification.tsx here:

onBackdropPress={User.clearFocusModeNotification}

ChavdaSachin commented 1 month ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb - Inbox - The "Focus" popup can´t be closed by tapping outside of it

What is the root cause of that problem?

We do not handle onBackdropPress and onCancel , hence user is not able to close it by clicking on background nor using back button.

What changes do you think we should make in order to solve the problem?

Add following props here, so user can close popup by clicking background and also using back button.
```
        onBackdropPress={User.clearFocusModeNotification}
        onCancel={User.clearFocusModeNotification}
```
https://github.com/Expensify/App/blob/476ad6bcca6de4faac6a41c37874fd9be62ddfe5/src/components/FocusModeNotification.tsx#L22-L45

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

VictoriaExpensify commented 3 weeks ago

Ok I think we should fix this, but it seems like a minor bug so I think we should reduce the bounty a bit. If I'm missing something to do with the complexity, please let me know