Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.89k forks source link

E-card transaction got added to a report that is already approved & forwarded #51498

Open m-natarajan opened 2 weeks ago

m-natarajan commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: Reproducible in production?: If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @youssef-lr Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729784068565829

Action Performed:

  1. Be on a corporate policy with advanced approvals, where the approver forwards to another approver (or the policy owner).
  2. As a member, create a a few manual expenses and submit them.
  3. As the first approver, approve the report which should forward it to the second approver.
  4. As the submitter, create an E-Card expense

Expected Result:

The E-Card expense should be added to a new report

Actual Result:

Ecard is added to the previous report.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence ![Screenshot 2024-10-24 at 16 31 21](https://github.com/user-attachments/assets/d8cf4b93-f6bf-485a-ba43-6c2b54845a19)

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @youssef-lr
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

alexpensify commented 2 weeks ago

@youssef-lr, are you going to grab this one, or should I label this one as a Hot Pick? Thanks!

youssef-lr commented 2 weeks ago

PR's ready for review!

melvin-bot[bot] commented 1 week ago

@alexpensify, @youssef-lr Whoops! This issue is 2 days overdue. Let's get this updated quick!

alexpensify commented 6 days ago

Update: Waiting for this one to go to production