Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.5k stars 2.85k forks source link

New Feature: "When to export" selector for auto-sync for NetSuite #51512

Open yuwenmemon opened 2 hours ago

yuwenmemon commented 2 hours ago

Hello! We need to build the following selector in the NetSuite configuration options: 364604714-6baa9d6b-fe87-43fd-bd28-d0844b9dc381

The "When to export" selector in the above mock-up is what we're adding.

The two options should have the following values (copied from the same feature in OldDot)

const accountingMethodOptions = [
    {
        value: 'ACCRUAL',
        text: 'Accrual',
        description: 'Out of pocket expenses will export when final approved',
    },
    {
        value: 'CASH',
        text: 'Cash',
        description: 'Out of pocket expenses will export when paid',
    },
];

Please use the constants defined in Expensify Common though: https://github.com/Expensify/expensify-common/pull/817

The selection should be saved under the property accountingMethod in the NetSuite options.config object.

If there is no accountingMethod property set in the NetSuite config, the selector should default to CASH

Linked Expensify Issue: https://github.com/Expensify/Expensify/issues/422402

Issue OwnerCurrent Issue Owner: @aimane-chnaif
melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @mallenexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 hours ago

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

yuwenmemon commented 2 hours ago

Removing NewFeature label since this does not fall under a project, and design has already reviewed.