Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.5k stars 2.85k forks source link

Search - Chats: docx/zip/txt/html files are present on Links tab #51529

Open lanitochka17 opened 4 hours ago

lanitochka17 commented 4 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.54-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3284915 Issue reported by: Applause - Internal Team

Action Performed:

Precondition: there are chats with sent links and files (txt, zip, html, docx)

  1. Go to Search > Chats
  2. Go to Links tab
  3. Go to Attachment tab

Expected Result:

On step 2: Sent messages with links are displayed On step 3: Sent files are displayed

Actual Result:

On step 2: Sent messages with links are displayed. Sent files (with formats txt/zip/docx/html) are also present on a tab. On step 3: Sent files are displayed (also files with formats txt/zip/docx/html)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/e1b4ecc3-1f41-442a-948d-65ed0f0dc7b2

View all open jobs on GitHub

melvin-bot[bot] commented 4 hours ago

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 4 hours ago

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 4 hours ago

We think that this bug might be related to #wave-control

Shahidullah-Muffakir commented 2 hours ago

This appears to be a backend filtering issue in the Search endpoint

  1. jsonQuery in the case of attachment; {"type":"chat","status":"attachments","sortBy":"date","sortOrder":"desc","filters":null,"inputQuery":"type:chat status:attachments sortBy:date sortOrder:desc","hash":34196984,"offset":0}
  2. jsonQuery in the case of links; {"type":"chat","status":"links","sortBy":"date","sortOrder":"desc","filters":null,"inputQuery":"type:chat status:links sortBy:date sortOrder:desc","hash":2089317297,"offset":0}

We are sending the correct status in each payload, but the Links response includes all chat types.