search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.5k stars 2.85k forks source link

Search - Tooltip is not displayed on the new Saved search indicating the name can be edited #51531

Open lanitochka17 opened 2 hours ago

lanitochka17 commented 2 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.54-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3284916 Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to the Search page
  2. Click on the filter icon
  3. Set a filter for the category “Advertising”
  4. Click on Save > Save Search button

Expected Result:

A new “Saved” section is displayed on the Search page navigation. A tooltip is displayed on the new Saved search indicating the name can be edited

Actual Result:

A tooltip is not displayed on the new Saved search indicating the name can be edited

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/97f93be2-d79a-40c2-813a-e76ad93c0f88

View all open jobs on GitHub

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 2 hours ago

We think that this bug might be related to #wave-control

Shahidullah-Muffakir commented 1 hour ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tooltip is not displayed on the saved search.

What is the root cause of that problem?

we are only showing the tooltip once, based on this comment and code: https://github.com/Expensify/App/blob/652d2ffa1b099f9c5a1f0cdce780792097f736ad/src/pages/Search/AdvancedSearchFilters.tsx#L290-L293

What changes do you think we should make in order to solve the problem?

if we want to show the tooltip each time a user save the search , we can remove the condition, and directly write: SearchActions.showSavedSearchRenameTooltip();

https://github.com/user-attachments/assets/d9be8cc9-ba0b-4a71-a38e-750fd6485410