[$250] 1:1 Submit expense - The receiving end of the IOU should not be asked to fill out information if the scan failed

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.54 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5121232&group_by=cases:section_id&group_order=asc&group_id=294998 Issue reported by: Applause - Internal Team

Action Performed:

1. Start the Submit expense flow in a 1:1 conversation with a user you have access to
2. Select the scan option
3. Upload a picture that will fail the scan process
4. Wait for the scan to fail
5. Log in as the other account
6. Navigate to the IOU that failed the scan
7. Verify the receiver is not asked to fill out the missing information

Expected Result:

The receiving end of the IOU should not be asked to fill out information if the scan failed

Actual Result:

The receiving end of the IOU is asked to fill out information if the scan failed but can't

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Standalone
• [ ] Android: HybridApp
• [ ] Android: mWeb Chrome
• [ ] iOS: Standalone
• [ ] iOS: HybridApp
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/7317ab19-6b6a-4337-91c2-e925dd5af6f4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021854642765194540226
• Upwork Job ID: 1854642765194540226
• Last Price Increase: 2024-11-14

Issue Owner

Current Issue Owner: @getusha

[melvin-bot[bot]]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

1:1 Submit expense - Scan failure should not ask receiver to enter information

What is the root cause of that problem?

We are displaying the same Enter an amount text for both side of the users https://github.com/Expensify/App/blob/c3dde46202d2f48934ef7aa617d69c8b4c0b5ff6/src/components/ReportActionItem/MoneyRequestView.tsx#L272

What changes do you think we should make in order to solve the problem?

We should display this copy only if the user canEditAmount and add another appropriate copy (like No amount set yet) and display it when the user can't modify the amount

                    translationPath: canEditAmount ? 'common.error.enterAmount' : 'common.error.noAmount',

We should do the same enterDate and enterMerchant

What alternative solutions did you explore? (Optional)

Optionally we can also avoid displaying the error for the receiving end

[alexpensify]

Adding to my testing list, I'll review this one soon.

[alexpensify]

No update yet

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021854642765194540226

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[alexpensify]

@getusha - can you please confirm if this proposal will fix this issue?

Heads up, I will be offline until Tuesday, November 12, 2024, and will not actively watch over this GitHub during that period.

If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If it can wait, I'll continue the review process when I return online. Thanks!

[FitseTLT]

@alexpensify The title of the issue should be updated according to the expected result

Expected Result: The receiving end of the IOU should not be asked to fill out information if the scan failed

[alexpensify]

Done! Thanks for the feedback.

[melvin-bot[bot]]

@alexpensify @getusha this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

@alexpensify, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[alexpensify]

@getusha any update regarding the review here? Thanks!

[melvin-bot[bot]]

@alexpensify, @getusha Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸