[$250] Over Limit Approver not seeing GBR or WS Chat unread when a report requires their approval

[garrettmknight]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: N/A Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @JmillsExpensify Slack conversation: https://expensify.slack.com/archives/C06ML6X0W9L/p1729859922259099?thread_ts=1729596983.599409&cid=C06ML6X0W9L

Action Performed:

1. Create Control workspace, invite Submitter, Approver A, Approver B
2. Set approval workflow in OldDot as Advanced Approval + Submitter > Approver A + Approver B as $10 overLimitForwardsTo
3. Confirm that Approver B has been invited to Submitters WS Chat by accessing the link to the WS chat (it shouldn't be unread or show up in LHN in focus mode)
4. As Submitter, create expense for + $10
5. As Approver B, click on the chat and then click away to another chat to make sure the WS chat is unread in your LHN
6. As Approver A, approve the expense

Expected Result:

Approver B should see that the WS Chat is GBR and unread.

Actual Result:

The WS Chat isn't unread for Approver B and there is no GBR. Once Approver B accesses the WS Chat GBR shows and persists.

Workaround:

No

Platforms:

All

Screenshots/Videos

https://github.com/user-attachments/assets/1be34913-9f5f-4fed-a4ff-1e5dc6335650

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021852100736496847321
• Upwork Job ID: 1852100736496847321
• Last Price Increase: 2024-10-31

Issue Owner

Current Issue Owner: @parasharrajat

[melvin-bot[bot]]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021852100736496847321

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[Beamanator]

This looks pretty fun & internal 👍

[Beamanator]

Finding some VERY interesting things while workin on this :D

[Beamanator]

Ready for review finally!

[Beamanator]

Hmm it looks like even submitting a report causes the next approver's overLimitForwardsTo to get the workspace chat unread, i think we have a bug for that somewhere right @garrettmknight ?

• Oh yeah, that's https://github.com/Expensify/App/issues/51723