[HOLD for payment 2024-11-18] [$250] iOS Company cards - View your subscription link opens Subscription page then back to Workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.55-6 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+kh2210008@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

1. Launch ND or hybrid app
2. Create a new workspace
3. Go to More features
4. Enable Company cards
5. Tap Upgrade
6. On upgrade success screen, tap View your subscription

Expected Result:

App will open subscription page

Actual Result:

App opens subscription page and then opens workspace editor page quickly. This issue only happens when upgrading workspace to Control from Company cards feature

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Standalone
• [ ] Android: HybridApp
• [ ] Android: mWeb Chrome
• [x] iOS: Standalone
• [x] iOS: HybridApp
• [x] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/1668819b-9687-4149-94cd-c38a4fee653d

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021853715612324216469
• Upwork Job ID: 1853715612324216469
• Last Price Increase: 2024-11-05
• Automatic offers:
• DylanDylann | Contributor | 104748690
• Nodebrute | Contributor | 104757262

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot[bot]]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-control

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-10-30 13:20:01 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

View your subscription link opens Subscription page then back to Workspace

What is the root cause of that problem?

Here we enable company cards, after enabling we are navigating the user to Workspace initial page https://github.com/Expensify/App/blob/ffc8c3d6c28ef684c4f0daf098760177a02ff0c0/src/libs/actions/Policy/Policy.ts#L2678-L2680

What changes do you think we should make in order to solve the problem?

We can pass a third parameter here disableRedirect = false https://github.com/Expensify/App/blob/ffc8c3d6c28ef684c4f0daf098760177a02ff0c0/src/libs/actions/Policy/Policy.ts#L2633

and then here we can use

    if (enabled && getIsNarrowLayout()  && !disableRedirect) {
        navigateWhenEnableFeature(policyID);
    }

and we can pass true here as third param https://github.com/Expensify/App/blob/ffc8c3d6c28ef684c4f0daf098760177a02ff0c0/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx#L77

This solution will make it consistent with other upgrade flows such as enablePolicyReportFields and enableCompanyCards

What alternative solutions did you explore? (Optional)

[melvin-bot[bot]]

@stephanieelliott Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021853715612324216469

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[DylanDylann]

cc @mountiny

[melvin-bot[bot]]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Handling this as part of the project where we have specific c+ assigned. @DylanDylann can you please review the proposal and if its not sufficient we can leave this for callstack

[DylanDylann]

@Nodebrute's proposal looks good to me

🎀 👀 🎀 C+ Reviewed

cc @mountiny

[melvin-bot[bot]]

Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[DylanDylann]

@Nodebrute If you get assigned, could you raise a PR soon?

[Nodebrute]

@DylanDylann I am available to raise the pr? should I wait for assignment?

[NikkiWines]

Yep, @Nodebrute's proposal looks good 👍

[melvin-bot[bot]]

📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.59-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/52050

If no regressions arise, payment will be issued on 2024-11-18. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @Nodebrute requires payment automatic offer (Contributor)
• @DylanDylann requires payment automatic offer (Contributor)

[melvin-bot[bot]]

@DylanDylann @stephanieelliott The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]