search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.9k forks source link

Submitting a expense to reports@expensify.com shows an error message #51773

Closed isagoico closed 1 week ago

isagoico commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A

Logs: https://stackoverflow.com/c/expensify/questions/4856

Issue reported by: @quinthar Slack conversation (hyperlinked to channel name): #expensify-bugs

Action Performed:

  1. Submit a expense to reports@expensify.com

Expected Result:

IG: Not completely sure about the expected result for this one, I think we either:

Actual Result:

An error message is displayed and the expense is not created after dismissing the error.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

image

https://github.com/user-attachments/assets/756c4bc7-112b-4dcf-9cbf-cc5d9aaff5e5

View all open jobs on GitHub

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Nodebrute commented 2 weeks ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submitting a expense to reports@expensify.com shows an error message

What is the root cause of that problem?

We have a list of system emails that block users from performing certain tasks, such as submitting expenses or assigning tasks to those emails. Currently, reports@expensify.com isn’t included in this list of system emails.

What changes do you think we should make in order to solve the problem?

Add account id of reports@expensify.com in this list which is 10840084 https://github.com/Expensify/App/blob/aa6401de4a3c02adce2cb898eba8c58e1c92b62d/src/CONST.ts#L1936

Also add this here https://github.com/Expensify/App/blob/aa6401de4a3c02adce2cb898eba8c58e1c92b62d/src/CONST.ts#L2895

Optional: to stop user from performing other tasks too Add reports@expensify.com in this list https://github.com/Expensify/App/blob/aa6401de4a3c02adce2cb898eba8c58e1c92b62d/src/CONST.ts#L1475

We should also add it here https://github.com/Expensify/App/blob/aa6401de4a3c02adce2cb898eba8c58e1c92b62d/src/CONST.ts#L2875

What alternative solutions did you explore? (Optional)

NJ-2020 commented 2 weeks ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submitting a expense to reports@expensify.com shows an error message

What is the root cause of that problem?

We did not block the user from sending to reports@expensify.com here https://github.com/Expensify/App/blob/aa6401de4a3c02adce2cb898eba8c58e1c92b62d/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx#L122 https://github.com/Expensify/App/blob/aa6401de4a3c02adce2cb898eba8c58e1c92b62d/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx#L185-L198

What changes do you think we should make in order to solve the problem?

We should add reports@expensify.com to get EXPENSIFY_EMAILS() function https://github.com/Expensify/App/blob/aa6401de4a3c02adce2cb898eba8c58e1c92b62d/src/CONST.ts#L2875-L2876 and here also https://github.com/Expensify/App/blob/aa6401de4a3c02adce2cb898eba8c58e1c92b62d/src/CONST.ts#L1475-L1476

OPTIONAL: We can also add reports@expensify.com to these functions https://github.com/Expensify/App/blob/aa6401de4a3c02adce2cb898eba8c58e1c92b62d/src/CONST.ts#L2916-L2927

What alternative solutions did you explore? (Optional)

FitseTLT commented 2 weeks ago

This is not a bug if it can't create a report with it, it will return an error. Same behavior for similar contacts; you can try it with test@expensify.com, for instance.

melvin-bot[bot] commented 1 week ago

@adelekennedy Huh... This is 4 days overdue. Who can take care of this?