search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.52k stars 2.87k forks source link

Web - Search - Group expense box is not highlighted evenly when selected by keyboard #51784

Open lanitochka17 opened 5 days ago

lanitochka17 commented 5 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.56-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: applausetester+kh2310001@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Submit two expenses to any user
  3. Go to Search
  4. Go to Outstanding
  5. Navigate to the group expenses in Step 2 using keyboard
  6. Click on the empty area to remove the blue border

Expected Result:

The group expense box will be highlighted evenly

Actual Result:

The top and bottom of the group expense box have different shade than the middle of the box

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence
99!highlight

https://github.com/user-attachments/assets/b1075f94-6178-4c98-8e77-2f6d226a75ca

View all open jobs on GitHub

github-actions[bot] commented 5 days ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 5 days ago

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 5 days ago

💬 A slack conversation has been started in #expensify-open-source

Nodebrute commented 5 days ago

Regression from https://github.com/Expensify/App/pull/51158

jjcoffee commented 5 days ago

@nkdengineer Can you take a look?

iwiznia commented 5 days ago

I don't think this is a blocker, but it seems the change created a bunch of other issues and is being reverted already.

Beamanator commented 2 days ago

Reverted in https://github.com/Expensify/App/pull/51795 & that was checked off by applause, so seems to be fixed!