search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.53k stars 2.88k forks source link

Group chat - Selected user is highlighted after clicking Add to group #51786

Open lanitochka17 opened 1 week ago

lanitochka17 commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.56-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+kh2310001@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Start chat
  3. Click Add to group next to user
  4. Click Next

Expected Result:

The selected user will not be highlighted (production behavior)

Actual Result:

The selected user is highlighted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/0fca6ff6-2ac2-4b9a-9e72-6457d1989f98

View all open jobs on GitHub

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 week ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
MuaazArshad commented 1 week ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Selected user is highlighted after clicking Add to group

What is the root cause of that problem?

We are adding a background colour to the selected user here https://github.com/Expensify/App/blob/9400244540e32e0bc40086566f16b4a8c7ae549e/src/components/SelectionList/BaseListItem.tsx#L107

What changes do you think we should make in order to solve the problem?

We should remove StyleUtils.getItemBackgroundColorStyle(!!item.isSelected, !!isFocused, theme.activeComponentBG, theme.hoverComponentBG) from https://github.com/Expensify/App/blob/9400244540e32e0bc40086566f16b4a8c7ae549e/src/components/SelectionList/BaseListItem.tsx#L107 as we don't need it here.

What alternative solutions did you explore? (Optional)

mjasikowski commented 1 week ago

Offending PR: https://github.com/Expensify/App/pull/51158

Beamanator commented 3 days ago

Reverted in https://github.com/Expensify/App/pull/51795 & that was checked off by applause, so seems to be fixed!

mjasikowski commented 15 hours ago

Fix was submitted in https://github.com/Expensify/App/pull/51937