Open garrettmknight opened 1 week ago
Triggered auto assignment to @trjExpensify (NewFeature
), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.
@garrettmknight Whoops! This issue is 2 days overdue. Let's get this updated quick!
Still discussing how best to implement.
We've landed on the high level, now we just need to recruit someone to build it!
Job added to Upwork: https://www.upwork.com/jobs/~021854205244452205878
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External
)
Edited by proposal-police: This proposal was edited at 2024-11-06 17:15:56 UTC.
Add route to WS chat in Workspace menu
This is a new feature request
We should get the policy expense report by filtering from allReports
. This will be the policy expense chat that has policyID
is the viewing policyID
and has isOwnPolicyExpenseChat
is true
. We can re-use getPolicyExpenseChat
function with ownerAccountID
is currentUserAccountID and the policyID
is the viewing policyID
After getting the report, we can add the text and LHN row below the workspace feature here
Add separator text below WS items in the WS details LHN that reads "Submit expenses using your workspace chat below:" Spanish translation: "Envíe los gastos utilizando el chat de su espacio de trabajo:"
MenuItem
component or other component like this. To get the avatar, we can use getIcons
function as we did here to get the icon of the policy expense chat. Then when we click on this row, we will navigate to the report screen with the reportID is the ID of the policy expense chat@shahinyan11 feel free to put a proposal together if you want. If @nkdengineer's isn't complete and yours is we'll assign you.
@garrettmknight Thanks. But @nkdengineer's proposal is good enough. I most likely won't propose.
@nkdengineer Thanks for the proposal. Overall looks good to me. (ownerAccountID does not have to be currentUserAccountID as employees should see the policy too).
🎀 👀 🎀 C+ reviewed Link to proposal
Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Setting this internal and hot pick to get the BE changes completed too.
@garrettmknight, @s77rt, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!
@grgia Can you review the approved proposal https://github.com/Expensify/App/issues/51851#issuecomment-2460730546
Whoops, I thought I already had- all yours @nkdengineer
Thanks, I will raise the PR soon.
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C07NMDKEFMH/p1730380892061729
Problem: Many users (like this one) are visibly confused about how to submit expenses for reimbursement to a workspace and find themselves in the Workspace menu during their search.
Solution: Let's add a route in the Workspace details page that navigates to the user's workspace chat for that workspace.
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @s77rt