Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.89k forks source link

[$250] [NewDot Feature Request] Add route to WS chat in Workspace menu #51851

Open garrettmknight opened 1 week ago

garrettmknight commented 1 week ago

Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C07NMDKEFMH/p1730380892061729

Problem: Many users (like this one) are visibly confused about how to submit expenses for reimbursement to a workspace and find themselves in the Workspace menu during their search.

Solution: Let's add a route in the Workspace details page that navigates to the user's workspace chat for that workspace.

image

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021854205244452205878
  • Upwork Job ID: 1854205244452205878
  • Last Price Increase: 2024-11-06
Issue OwnerCurrent Issue Owner: @s77rt
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @trjExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 week ago

@garrettmknight Whoops! This issue is 2 days overdue. Let's get this updated quick!

garrettmknight commented 1 week ago

Still discussing how best to implement.

garrettmknight commented 6 days ago

We've landed on the high level, now we just need to recruit someone to build it!

melvin-bot[bot] commented 6 days ago

Job added to Upwork: https://www.upwork.com/jobs/~021854205244452205878

melvin-bot[bot] commented 6 days ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

nkdengineer commented 6 days ago

Edited by proposal-police: This proposal was edited at 2024-11-06 17:15:56 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add route to WS chat in Workspace menu

What is the root cause of that problem?

This is a new feature request

What changes do you think we should make in order to solve the problem?

  1. We should get the policy expense report by filtering from allReports. This will be the policy expense chat that has policyID is the viewing policyID and has isOwnPolicyExpenseChat is true. We can re-use getPolicyExpenseChat function with ownerAccountID is currentUserAccountID and the policyID is the viewing policyID

  2. After getting the report, we can add the text and LHN row below the workspace feature here

Add separator text below WS items in the WS details LHN that reads "Submit expenses using your workspace chat below:" Spanish translation: "Envíe los gastos utilizando el chat de su espacio de trabajo:"

What alternative solutions did you explore? (Optional)

garrettmknight commented 6 days ago

@shahinyan11 feel free to put a proposal together if you want. If @nkdengineer's isn't complete and yours is we'll assign you.

shahinyan11 commented 6 days ago

@garrettmknight Thanks. But @nkdengineer's proposal is good enough. I most likely won't propose.

s77rt commented 6 days ago

@nkdengineer Thanks for the proposal. Overall looks good to me. (ownerAccountID does not have to be currentUserAccountID as employees should see the policy too).

🎀 👀 🎀 C+ reviewed Link to proposal

melvin-bot[bot] commented 6 days ago

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

garrettmknight commented 5 days ago

Setting this internal and hot pick to get the BE changes completed too.

melvin-bot[bot] commented 1 day ago

@garrettmknight, @s77rt, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

s77rt commented 1 day ago

@grgia Can you review the approved proposal https://github.com/Expensify/App/issues/51851#issuecomment-2460730546

grgia commented 23 hours ago

Whoops, I thought I already had- all yours @nkdengineer

nkdengineer commented 23 hours ago

Thanks, I will raise the PR soon.