[HOLD for payment 2024-11-13] [HOLD for payment 2024-11-11] [$250] [Performance] HybridApp iOS: Firebase crash - facebook::jsi::JSError

[muttmuure]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

What performance issue do we need to solve?

Firebase crash here:

https://console.firebase.google.com/u/0/project/expensify-mobile-app/crashlytics/app/ios:com.expensify.expensifylite/issues/6c81436592b37f898c07cab55a30a83a?time=last-seven-days&types=crash&versions=9.0.56%20(9.0.56.0)&sessionEventKey=e05c506c93834ffb8281b148f87b6459_2010479564232592518

What is the impact of this on end-users?

Reported here: https://expensify.slack.com/archives/C05LX9D6E07/p1730395726205249

List any benchmarks that show the severity of the issue

14 sessions so far

Proposed solution (if any)

Please list out the steps you think we should take to solve this issue.

Investigate and fix

List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)

Note: These should be the same as the benchmarks collected before any changes.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Version Number: Reproducible in staging?: Reproducible in production?: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

View all open jobs on Upwork

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021852337274739729797
• Upwork Job ID: 1852337274739729797
• Last Price Increase: 2024-11-01

Issue Owner

Current Issue Owner: @ZhenjaHorbach

[melvin-bot[bot]]

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

[melvin-bot[bot]]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

💬 A slack conversation has been started in #expensify-open-source

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

Fatal Exception: facebook::jsi::JSError
Exception in HostFunction: Unhandled JS Exception: RangeError: Maximum call stack size exceeded This error is located at: in ReportIDsContextProvider in ActiveWorkspaceContextProvider in Ac..., stack: getRootParentReport@1:2745489 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:274552

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021852337274739729797

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[arosiclair]

Working on getting the latest TestFlight version of HybridApp. My old version v9.0.47-4 is loading without any crashes.

[arosiclair]

Okay updated to v9.0.56-3 and see no immediate crashes yet. The exception from Firebase seems to be related to threads:

Fatal Exception: facebook::jsi::JSError
Exception in HostFunction: Unhandled JS Exception: RangeError: Maximum call stack size exceeded This error is located at: in ReportIDsContextProvider in ActiveWorkspaceContextProvider in Ac..., stack: getRootParentReport@1:2745489 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 get

[arosiclair]

I can't reproduce the issue, but I'm pretty sure it has to do with some bugged thread report that @ryanschaffer has. I'm adding cycle detection to getRootParentReport to prevent infinite loops and I'll also log which reports are causing the issue.

[Beamanator]

Well the PR was CP'd, can we now call this NAB / fixed @arosiclair ? 🙏 There's no test steps in the PR

[Beamanator]

Removing Help Wanted b/c it looks like we already have a PR to fix this?

[Julesssss]

Fix was CPd and was confirmed fixed 🎉

I'm removing the blocker label and closing the Firebase issue.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.56-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/51879

If no regressions arise, payment will be issued on 2024-11-11. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @ZhenjaHorbach requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.57-10 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/51879

If no regressions arise, payment will be issued on 2024-11-13. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @ZhenjaHorbach requires payment (Needs manual offer from BZ)