search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.87k forks source link

Bank Account - Validating account with wrong numbers takes you to "Connect Bank Account" #51854

Open lanitochka17 opened 3 hours ago

lanitochka17 commented 3 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.56-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5173639 Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. profile icon > workspaces > enable workflow
  3. Tap workflow in workspace settings > connect bank account
  4. Select the Manual method to add a bank account
  5. Go through the flow until "Validate account" page
  6. Submit three random amounts

Expected Result:

"The validate code you entered is incorrect, please try again" error is shown in "Validate account" page

Actual Result:

User is navigated to "Connect bank account" page. "The validate code you entered is incorrect, please try again" error is shown in "Connect bank account" page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/44f7c09e-3a15-4d58-8851-e7e6426ae627

View all open jobs on GitHub

melvin-bot[bot] commented 3 hours ago

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 3 hours ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 3 hours ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
lanitochka17 commented 3 hours ago

The same thing happens when you click "continue" button on "complete verification" page also takes you to "Connect Bank Account" page Clicking "continue" button should take to "Validation" page.

https://github.com/user-attachments/assets/0b622cc0-7db9-47f5-9f6c-b5fcd24a5f9d

lakchote commented 3 hours ago

There's a high probability it's related to https://github.com/Expensify/App/pull/51315

DylanDylann commented 3 hours ago

Let's me check

lakchote commented 3 hours ago

I've verified @DylanDylann and it's the culprit.