[$250] Expensify Card - Verifying page does not show offline indication when user is offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.56-3 Reproducible in staging?: Y Reproducible in production?: Unable to check If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):applausetester+khcategory18@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Expensify Card
3. Click Issue new card
4. Add a bank account if not yet
5. Go offline
6. Select the added bank account

Expected Result:

Verifying page will show that user is offline

Actual Result:

Verifying page shows the animation as long as user is offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Standalone
• [x] Android: HybridApp
• [x] Android: mWeb Chrome
• [ ] iOS: Standalone
• [x] iOS: HybridApp
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/34fb3f04-9278-4a10-9d47-667c547c759e

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021852431360082320267
• Upwork Job ID: 1852431360082320267
• Last Price Increase: 2024-11-01

Issue Owner

Current Issue Owner: @ahmedGaber93

[melvin-bot[bot]]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

💬 A slack conversation has been started in #expensify-open-source

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Verifying page does not show offline indication when user is offline

What is the root cause of that problem?

Currently, to display the offline indicator on wider screens, we need to use the shouldShowOfflineIndicatorInWideScreen prop, which is missing in this instance. https://github.com/Expensify/App/blob/b9ec75ae4977b6df52912dae4cdab53ab7973701/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx#L181

What changes do you think we should make in order to solve the problem?

we can pass shouldShowOfflineIndicatorInWideScreen here if we want to show the offline indicator in wider screens https://github.com/Expensify/App/blob/b9ec75ae4977b6df52912dae4cdab53ab7973701/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx#L181

Optionally we can add offlineIndicatorStyle={styles.mtAuto} so in android the indicator stays below the content

What alternative solutions did you explore? (Optional)

Alternatively, we can add shouldShowOfflineIndicator here https://github.com/Expensify/App/blob/b9ec75ae4977b6df52912dae4cdab53ab7973701/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx#L181

[francoisl]

Sounds like it could come from https://github.com/Expensify/App/pull/51407. The proposal makes sense to me, going to label External to get a second pair of eyes on it.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021852431360082320267

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)