Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[HOLD for payment 2024-11-22] [Workspace feeds] Card art on card details page looks a bit smaller than the mockups #51910

Open m-natarajan opened 2 weeks ago

m-natarajan commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: needs reproduction Reproducible in production?: needs reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @joekaufmanexpensify Slack conversation (hyperlinked to channel name): quality

Action Performed:

Prerequisite: Members and company cards added in workspace , 8+ export options for card

  1. Go to staging.new.expensify.com
  2. Choose the workspace from settings
  3. Click company cards >Card Details

Expected Result:

Card art on the card details should match the mocks

Actual Result:

Card art on card details page looks a good bit smaller than the mockups, and compared to analogous pages for Expensify Card.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence ![image - 2024-10-31T152943 856](https://github.com/user-attachments/assets/8ed3e674-fddd-47dc-b4c2-3fe297242e22) ![image - 2024-10-31T152932 168](https://github.com/user-attachments/assets/32220c5a-aac5-41dd-89e9-f7f32d8c18d9)

View all open jobs on GitHub

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @Julesssss (AutoAssignerNewDotQuality)

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

m-natarajan commented 2 weeks ago

BZ team member, Callstack will work on this issue, please wait for them to comment before moving the issue forward.

MelvinBot commented 2 weeks ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

mountiny commented 2 weeks ago

Handling this as part of the project I have worked on

waterim commented 1 week ago

Hello, Im Artem from Callstack and would like to help with this issue!

mountiny commented 1 week ago

assigned, thanks

waterim commented 1 week ago

@mountiny Here is an issue with exported SVGs we have It has sizes defined in svg itself for icons(for selections list, list of cards etc.) and all of the cards have size: viewBox="0 0 40 40" While expensify card has viewBox="0 0 235 148"

And I cant just change the size with ignoring aspect ratio because svg is not optimized for this scale and looks like this:

image

I think we need to devide icons company cards and full big card images with another aspect ratio

Some designer is needed here for exporting all correct card images

waterim commented 1 week ago

I need: Amex, BOA, CapitalOne, Chase, Citibank, WellsFargo, BrexCompany, Stripe, Other

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

mountiny commented 1 week ago

👋 any chance you could help with the request above? @dannymcclain thanks!

dannymcclain commented 1 week ago

Absolutely. I'll upload the updated card SVGs here once I get a chance to make them! We can't be showing squish squashed cards in the app 😂

mountiny commented 1 week ago

@dannymcclain friendly bump

dannymcclain commented 1 week ago

Getting to this today!

dannymcclain commented 1 week ago

Alright let's try these:

Card Images - Large.zip

allgandalf commented 4 days ago

@waterim do you think you can get the PR up for review today ?

melvin-bot[bot] commented 1 day ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 day ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.62-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 1 day ago

@allgandalf @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]