Open m-natarajan opened 3 weeks ago
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
Triggered auto assignment to @isabelastisser (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Triggered auto assignment to @mjasikowski (AutoAssignerNewDotQuality
)
Will look into this today
Can reproduce on staging & production, but not on dev
Works fine consistently on Firefox, I can only reproduce this in Chrome so far.
Can be reproduced in Chrome on dev with ENVIRONMENT=production
.
It seems that despite receiving correct token, Plaid's onLoad() is never called in production build in Chrome.
Hey, @MichaelBuhler, should this issue be assigned to an external contributor or one of our engineers?
@isabelastisser let's make it external, it's a pure front-end problem.
Job added to Upwork: https://www.upwork.com/jobs/~021854106024301234049
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External
)
Hi there. @mjasikowski Could you please tell me which file should I make the following changes ENVIRONMENT=production
in?. And I want to clarify the behavior. Is it expected to always open Plaid when working properly ?
@shahinyan11 here's how I managed to reproduce this with my limited testing:
.env
file by adding ENVIRONMENT=production
to the end of the file (or changing the environment in the file to production if it's already there)npm run web
This should always open Plaid. Currently there's an activity indicator and it just spins indefinitely. I couldn't replicate this in Firefox. As mentioned in the comment above, it seems that a relevant onLoad() function is just never called.
Looks like mjasikowski was right we need to call the onLoad function
📣 @Anastasiia-F! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Contributor details Your Expensify account email: afesenk@gmail.com Upwork Profile Link: Upwork
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
@mjasikowski, @isabelastisser, @ishpaul777 Huh... This is 4 days overdue. Who can take care of this?
No proposals
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
no proposals to review
Investigated this a bit more, it seems that Chrome is refusing to load the plaid script fetched dynamically from their CDN, but only in production mode:
I've tested this on multiple setups:
MacOS 15.1 (Macbook Pro M3 Max)
MacOS 14.5 (Macbook Pro M1 Pro)
MacOS 15.0 (Macbook Air M2)
MacOS 14.2.1 (Mac mini M1)
Windows 11 (Intel laptop)
The root cause of the issue is the react-plaid-link
npm package creating a <script>
node in DOM, which should load link-initialize.js
from Plaid's CDN, but in some cases the network request just stalls, preventing Plaid's iframe to load.
Upwork job price has been updated to $500
Issue not reproducible during KI retests. (First week)
@mjasikowski @isabelastisser @ishpaul777 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
no proposal to review, i'll advertise this on slack
@ishpaul777 Did you able to reproduce this issue?
I can reproduce on production but not on staging and dev
https://github.com/user-attachments/assets/d833d47e-bbe1-42de-ba8f-61d749318544
Hi, I'm Eto from Callstack - expert contributor group - and I would like to take look at this issue.
@teneeto go ahead and let me know if you need any help - I can reproduce this reliably in my local dev environment.
Repro update: this works fine when running Chrome from a different data directory, eg. if you run open -na Google\ Chrome\ Dev --args --user-data-dir=/tmp/temporary-chrome-profile-dir
from terminal. Possibly a caching bug in Chrome?
Hi, I'm Julian from Callstack - expert contributor group - and I would like to take look at this issue.
@mjasikowski
@JKobrynski will take over the issue from @teneeto since he will be OOO for some time.
not overdue, @mjasikowski Can you please assign @JKobrynski
📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Issue not reproducible during KI retests. (Second week)
@mjasikowski, @isabelastisser, @JKobrynski, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@JKobrynski any progress here?
@mjasikowski not yet, investigation in progress
not overdue, update ^
So far I haven't been able to reproduce the issue in dev with ENVIRONMENT=production
and I also haven't been able to do it in the production app. I think the reason might be the system that I'm using, currently I'm on MacOS Sonoma 14.6.1, Chrome 131 and it doesn't reproduce for me.
I'm going to update my OS and Chrome and retest.
I updated my OS and tried reproducing the bug but once again, no success. I'm currently on macOS Sequoia 15.1.1 and I wasn't able to reproduce the bug in the production app, nor have I been able to do it in dev with ENVIRONMENT=production
.
Can we somehow verify if this is still happening?
I could not reproduce any more checked on staging, production and dev it got redirected to plaid flow successfully
For some reason I'm still able to consistently reproduce it on my end. @JKobrynski we can jump on a call and do a screenshare if you'd like
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: Reproducible in staging?: Needs reproduction Reproducible in production?: Needs reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @quinthar Slack conversation (hyperlinked to channel name): #quality
Action Performed:
Expected Result:
User able to continue and add a bank account
Actual Result:
Continuous loading spinner displayed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/44a2f8e5-feae-4bb0-9a48-52dbc0963934 ``` [info] [API] Called API write - {"command":"CompleteGuidedSetup","engagementChoice":"newDotLookingAround","firstName":"David","lastName":"Barrett (EXFY CEO)","actorAccountID":8392101,"guidedSetupData":"[{\"type\":\"message\",\"reportID\":\"61204031\",\"reportActionID\":\"3516336773692675037\",\"reportComment\":\"Let's get you set upView all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ishpaul777