Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.87k forks source link

Loading spinner when adding a invoice bank account #51919

Open m-natarajan opened 2 hours ago

m-natarajan commented 2 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: Needs reproduction Reproducible in production?: Needs reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @quinthar Slack conversation (hyperlinked to channel name): #quality

Action Performed:

  1. Go to Go to staging.new.expensify.com
  2. Create a Workspace or go to workspace through settings
  3. Enable Invoices > Connect bank account

    Expected Result:

    User able to continue and add a bank account

    Actual Result:

    Continuous loading spinner displayed

    Workaround:

    Unknown

    Platforms:

    Which of our officially supported platforms is this issue occurring on?

    • [ ] Android: Standalone
    • [ ] Android: HybridApp
    • [ ] Android: mWeb Chrome
    • [ ] iOS: Standalone
    • [ ] iOS: HybridApp
    • [ ] iOS: mWeb Safari
    • [x] MacOS: Chrome / Safari
    • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence https://github.com/user-attachments/assets/44a2f8e5-feae-4bb0-9a48-52dbc0963934 ``` [info] [API] Called API write - {"command":"CompleteGuidedSetup","engagementChoice":"newDotLookingAround","firstName":"David","lastName":"Barrett (EXFY CEO)","actorAccountID":8392101,"guidedSetupData":"[{\"type\":\"message\",\"reportID\":\"61204031\",\"reportActionID\":\"3516336773692675037\",\"reportComment\":\"Let's get you set up 🔧\"},{\"type\":\"message\",\"reportID\":\"61204031\",\"reportActionID\":\"2929353029631138233\",\"reportComment\":\"Expensify is best known for expense and corporate card management, but we do a lot more than that. Let me know what you're interested in and I'll help get you started.\"}]"} Log.ts:76 [info] [API] Preparing request - {"command":"CompleteGuidedSetup","type":"write"} Log.ts:76 [info] [API] Applying optimistic data - {"command":"CompleteGuidedSetup","type":"write"} Log.ts:76 [info] [Onyx] set called for key: networkRequestQueue properties: 0 hasChanged: true - "" Log.ts:76 [info] [Onyx] set called for key: plaidLinkToken hasChanged: false - "" Log.ts:76 [info] [Onyx] set called for key: plaidData properties: bankName,plaidAccessToken,bankAccounts,isLoading,errors hasChanged: false - "" Log.ts:76 [info] [Network] Making API request - {"command":"CompleteGuidedSetup"} {request: {…}, response: undefined} Log.ts:76 [info] [Onyx] merge called for key: report_61204031 properties: lastMentionedTime,hasOutstandingChildTask hasChanged: true - "" Log.ts:76 [info] [Onyx] merge called for key: reportActions_61204031 properties: 3516336773692675037,2929353029631138233 hasChanged: true - "" Log.ts:76 [info] [Onyx] merge called for key: nvp_introSelected properties: choice hasChanged: false - "" Log.ts:76 [info] [Onyx] merge called for key: nvp_onboarding properties: hasCompletedGuidedSetupFlow hasChanged: false - "" Log.ts:76 [info] Not switching user to optimized focus mode. - {"isInFocusMode":true,"hasTriedFocusMode":true} Log.ts:76 [info] [API] Called API.read - {"command":"OpenPlaidBankLogin","redirectURI":"https://staging.new.expensify.com/bank-account","allowDebit":false,"bankAccountID":0} Log.ts:76 [info] [API] Preparing request - {"command":"OpenPlaidBankLogin","type":"read"} Log.ts:76 [info] [API] Applying optimistic data - {"command":"OpenPlaidBankLogin","type":"read"} Log.ts:76 [info] [API] 'OpenPlaidBankLogin' is waiting on 1 write commands - "" Log.ts:76 [info] Navigating to route - {"path":"/settings/wallet/add-bank-account"} Log.ts:76 [info] [Onyx] set called for key: plaidData properties: bankName,plaidAccessToken,bankAccounts,isLoading,errors hasChanged: true - "" Log.ts:76 [info] [Onyx] set called for key: plaidLinkToken hasChanged: false - "" Log.ts:76 [info] [Onyx] merge called for key: modal properties: isVisible hasChanged: true - "" Log.ts:76 [info] [Onyx] merge called for key: lastVisitedPath hasChanged: true - "" Log.ts:76 [info] [Onyx] merge called for key: reimbursementAccountDraft properties: plaidAccountID hasChanged: false - "" Log.ts:76 [info] [SequentialQueue] 'CompleteGuidedSetup' command queued. Queue length is 1 - "" Log.ts:76 [info] [Network] Finished API request in 450ms - {"command":"CompleteGuidedSetup","jsonCode":200,"requestID":"8dbe8fc4aa3b0954-SEA"} {request: {…}, response: {…}} OnyxUpdates.ts:29 [OnyxUpdateManager] Applying https update Log.ts:76 [info] [OnyxUpdateManager] Applying update type: https with lastUpdateID: 2725453769 - {"command":"CompleteGuidedSetup"} Log.ts:76 [info] [Onyx] merge called for key: OnyxUpdatesLastUpdateIDAppliedToClient hasChanged: true - "" OnyxUpdates.ts:64 [OnyxUpdateManager] Done applying HTTPS update Log.ts:76 [info] [RequestThrottle] in clear() - "" Log.ts:76 [info] [SequentialQueue] Unable to process. No requests to process. - "" Log.ts:76 [info] [SequentialQueue] Finished processing queue. - "" Log.ts:76 [info] [Network] Making API request - {"command":"OpenPlaidBankLogin"} {request: {…}, response: undefined} Log.ts:76 [info] [Onyx] merge called for key: report_61204031 properties: participants,chatType,description,lastActorAccountID,lastMessageText,lastVisibleActionCreated,managerID,ownerAccountID,parentReportActionID,parentReportID,policyID,reportID,reportName,state,stateNum,statusNum,type,visibility hasChanged: true - "" Log.ts:76 [info] [Onyx] merge called for key: reportActions_61204031 properties: 3516336773692675037,2929353029631138233 hasChanged: true - "" Log.ts:76 [info] [Onyx] merge called for key: personalDetailsList properties: 8392101 hasChanged: false - "" Log.ts:76 [info] Not switching user to optimized focus mode. - {"isInFocusMode":true,"hasTriedFocusMode":true} Log.ts:76 [info] [SequentialQueue] 'CompleteGuidedSetup' removed from the queue. Queue length is 0 - "" Log.ts:76 [info] [Onyx] merge called for key: snapshot_243428839 properties: data hasChanged: false - "" Log.ts:76 [info] [Network] Finished API request in 742ms - {"command":"OpenPlaidBankLogin","jsonCode":200,"requestID":"8dbe8fc6ab230954-SEA"} {request: {…}, response: {…}} OnyxUpdates.ts:29 [OnyxUpdateManager] Applying https update Log.ts:76 [info] [OnyxUpdateManager] Applying update type: https with lastUpdateID: 0 - {"command":"OpenPlaidBankLogin"} Log.ts:76 [info] [Onyx] set called for key: plaidLinkToken hasChanged: true - "" Log.ts:76 [info] [Onyx] set called for key: isPlaidDisabled hasChanged: false - "" OnyxUpdates.ts:64 [OnyxUpdateManager] Done applying HTTPS update Log.ts:76 [info] Flushing logs as app is going inactive - {} Log.ts:76 [info] Previous log requestID - {"requestID":"8dbe908b8df60954-SEA"} OnyxUpdates.ts:29 [OnyxUpdateManager] Applying https update Log.ts:76 [info] [OnyxUpdateManager] Applying update type: https with lastUpdateID: 0 - {"command":"Log"} OnyxUpdates.ts:64 [OnyxUpdateManager] Done applying HTTPS update Log.ts:76 [info] [Onyx] set called for key: activeClients properties: 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17 hasChanged: false - "" ```

View all open jobs on GitHub

MelvinBot commented 2 hours ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @mjasikowski (AutoAssignerNewDotQuality)