Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.52k stars 2.88k forks source link

[HOLD for payment 2024-11-13] [WAIT FOR PAYMENT - 14th November] Room - App crashes after submitting expense to user or creating a new room #51959

Open IuliiaHerets opened 2 days ago

IuliiaHerets commented 2 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.57-0 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+kh22100010ad@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com

  2. Go to FAB > Submit expense.

  3. Enter amount > Next.

  4. Select a user that has no previous chat.

  5. Submit the expense.

  6. Go to staging.new.expensify.com

  7. Go to FAB > Start chat.

  8. Go to Room.

  9. Create a new room.

Expected Result:

App will not crash.

Actual Result:

App crashes after submitting expense to user or creating a new room. It also crashes by just opening new chat.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/b1b7c9fb-d6bd-4460-987a-9ce41389650f

0411_1.txt

https://github.com/user-attachments/assets/bbfda954-5522-40b6-ac9d-f805c18a3305

View all open jobs on GitHub

melvin-bot[bot] commented 2 days ago

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 2 days ago

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 days ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 2 days ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 2 days ago

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

flodnv commented 2 days ago

Thanks, CP requested.

Julesssss commented 1 day ago

@flodnv did the CP resolve the issue? I don't see any comments on the checklist or PR post-CP confirming the issue was resolved.

If it wasn't verified I will ask QA to retest. I asked QA to test here.

Julesssss commented 1 day ago

Verified fixed: https://github.com/Expensify/App/pull/51973#issuecomment-2456925746

Julesssss commented 1 day ago

I believe the only remaining task here is payment for @rojiphil's C+ review

melvin-bot[bot] commented 23 hours ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 23 hours ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.57-10 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-13. :confetti_ball:

melvin-bot[bot] commented 23 hours ago

@flodnv The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

flodnv commented 8 hours ago

@slafortune can you please process payment for @rojiphil's review https://github.com/Expensify/App/issues/51959#issuecomment-2456942709 and then close this issue?