Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.58k stars 2.92k forks source link

[Search v2.5] Update grammar filters #51966

Open luacmartins opened 3 weeks ago

luacmartins commented 3 weeks ago

Coming from this comment, we want to update the filter grammar to use kebab case instead of camel case so it's a bit more friendly to users. Here are the filters that need to be updated:

Issue OwnerCurrent Issue Owner: @luacmartins
melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @anmurali (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

289Adam289 commented 3 weeks ago

Hi! While working on the search parser, I noticed a feature in Peggy that could be beneficial. What's your opinion on making grammar keys case-insensitive, allowing from and From to function identically? It should be easy to implement by adding letter i at the end of a literal in the grammar e.g. "from" will become "from"i. I think this feature would be useful and make the Search Router easier to use.

luacmartins commented 3 weeks ago

Sounds like a nice improvement, let's do it.!

rayane-djouah commented 2 weeks ago
  • reportID to reportid

I think report or report-name is better than reportid, in my opinion, since we type the report name, not the ID.

luacmartins commented 1 week ago

Not a priority