search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

[Workspace Feeds] Adding additional feed overwrites the existing feed #52002

Open m-natarajan opened 2 weeks ago

m-natarajan commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: Reproducible in staging?: need reproduction Reproducible in production?: need reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @joekaufmanexpensify Slack conversation (hyperlinked to channel name): quality

Action Performed:

  1. Set up a Visa feed
  2. Add additional Visa feed with existing one

    Expected Result:

    2nd Visa card should be showing as pending

    Actual Result:

    Existing already added visa card is overwritten NOTE : Issue not happening with different types of card feed

    Workaround:

    unknown

    Platforms:

    Which of our officially supported platforms is this issue occurring on?

    • [ ] Android: Standalone
    • [ ] Android: HybridApp
    • [ ] Android: mWeb Chrome
    • [ ] iOS: Standalone
    • [ ] iOS: HybridApp
    • [ ] iOS: mWeb Safari
    • [x] MacOS: Chrome / Safari
    • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence https://github.com/user-attachments/assets/58a4d6a1-1d5b-47d1-b964-6dbb97c41274

View all open jobs on GitHub

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 weeks ago

Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

mountiny commented 2 weeks ago

I think we might need to pass updated name like vcf2

m-natarajan commented 2 weeks ago

BZ team member, Callstack will work on this issue, please wait for them to comment before moving the issue forward.

mountiny commented 2 weeks ago

As discussed in slack here https://expensify.enterprise.slack.com/archives/C05LX9D6E07/p1730794651148409?thread_ts=1730755550.229969&channel=C05LX9D6E07&message_ts=1730794651.148409 right now we are intentionally overwriting the feed when we add a new one of the same type.

We will need to build this support into newDot. We can try to use the feedID locally and increment it and handle any errors due to existing feed with this feed id using the rbr

mountiny commented 1 week ago

Still to be handled

melvin-bot[bot] commented 4 days ago

@garrettmknight @mountiny this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

mountiny commented 3 days ago

not worked on yet

mountiny commented 2 days ago

Weekly