search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

[$250] Workspace - Workspace isn't appearing in the list after navigating to the join link #52041

Open izarutskaya opened 2 weeks ago

izarutskaya commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.57-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5175877&group_by=cases:section_id&group_id=229065&group_order=asc Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

Preconditions:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with a new Gmail account
  3. Navigate to https://staging.new.expensify.com/settings/workspaces/3C97A0E1C9B0F52A/join?email=applausetester+joinlink@applause.expensifail.com

Expected Result:

Workspace should appear and the join request is sent

Actual Result:

Workspace isn't appearing in the list after navigating to the join link.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/3314a090-1865-4edb-8286-0ff3fadd0a97

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021856643804711680870
  • Upwork Job ID: 1856643804711680870
  • Last Price Increase: 2024-11-20
Issue OwnerCurrent Issue Owner: @ikevin127
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

daledah commented 2 weeks ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace isn't appearing in the list after navigating to the join link.

What is the root cause of that problem?

https://github.com/Expensify/App/blob/e2987bdedbbb47ee9cc1404f0c2e6557edc3d786/src/pages/workspace/WorkspacesListPage.tsx#L310

In that function, we check !!getPolicyRole(policy, currentUserLogin) which will return false in case of policy that is pending join

https://github.com/Expensify/App/blob/e2987bdedbbb47ee9cc1404f0c2e6557edc3d786/src/libs/PolicyUtils.ts#L194

What changes do you think we should make in order to solve the problem?

        (!!getPolicyRole(policy, currentUserLogin) || !!policy?.isJoinRequestPending)

The detail code changes could be addressed when implementing PR.

What alternative solutions did you explore? (Optional)

VictoriaExpensify commented 1 week ago

It seems like this issue is specific to the tester environment - is that correct? If so, is it preventing you from being able to complete vital tests?

VictoriaExpensify commented 1 week ago

Asked Applause for more info on this https://expensify.slack.com/archives/C9YU7BX5M/p1731308225221119

daledah commented 1 week ago

I can reproduce the bug based on the test steps in OP

izarutskaya commented 1 week ago

Hi @VictoriaExpensify We are following the steps from TR and according to the steps we must see new line with workspace (in which join link was executed) and user sees chip with text "Requested" but when we navigate to link from step 3 we cannot see any workspace with text "Requested"

Screenshot 2024-11-11 124315

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~021856643804711680870

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

ikevin127 commented 1 week ago

♻️ Reviewing today.

ikevin127 commented 1 week ago

I'm not able to reproduce the issue, this is what I tried:

[!tip]

  1. Logged in with new gmail account (unverified) / also logged in with new gmail account (verified this one) - tested both local dev and staging.
  2. Pasted https://staging.new.expensify.com/settings/workspaces/3C97A0E1C9B0F52A/join?email=applausetester+joinlink@applause.expensifail.com and navigated to the URL.

In both scenarios the WS does show up in the list once navigated with the Requested badge:

Video https://github.com/user-attachments/assets/b20997c1-5e2e-49c8-98fb-5c087afb09c2

@daledah If you have other test steps to consistently reproduce this please let me know and if I will be able to reproduce I can move on with reviewing your proposal and testing if it fixes the issue.

cc @VictoriaExpensify for context.

melvin-bot[bot] commented 2 days ago

@VictoriaExpensify @ikevin127 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 2 days ago

@VictoriaExpensify, @ikevin127 Eep! 4 days overdue now. Issues have feelings too...

ikevin127 commented 2 days ago

Not able to reproduce, callback to https://github.com/Expensify/App/issues/52041#issuecomment-2475167265.

melvin-bot[bot] commented 1 day ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸