search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.9k forks source link

[$250] Wallet - Statement is not downloaded #52046

Open lanitochka17 opened 1 week ago

lanitochka17 commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.57-7 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+bp2510@applause.expensifail.com Issue reported by: Applause - Internal Team

Issue found when executing PR https://github.com/Expensify/App/pull/51626

Action Performed:

Precondition: account with enabled wallet.

  1. Go to URL https://staging.new.expensify.com/statements/ {yyyy}{mm}
  2. Click on Download button

Expected Result:

  1. Tab with month statement is opened
  2. Statement is downloaded

Actual Result:

  1. Tab with month statement is opened. Placeholder instead of info is displayed
  2. Statement is not downloaded
  3. New browser tab expensify.com is opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/79ffab32-7d2c-4e26-b861-93123bdc544d

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021854481819415295170
  • Upwork Job ID: 1854481819415295170
  • Last Price Increase: 2024-11-07
Issue OwnerCurrent Issue Owner: @dukenv0307
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Christinadobrzyn commented 1 week ago

I don't think we're working on Wallet right now. Asking the team - https://expensify.slack.com/archives/C06ML6X0W9L/p1730866894043029

MelvinBot commented 1 week ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Christinadobrzyn commented 1 week ago

Taking convo to quality - https://expensify.slack.com/archives/C05LX9D6E07/p1730884730445159

Christinadobrzyn commented 1 week ago

bumping convo in quality - https://expensify.slack.com/archives/C05LX9D6E07/p1730963737370759

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~021854481819415295170

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

Anaslancer commented 1 week ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wallet - Statement is not downloaded

What is the root cause of that problem?

There are 3 problems according to Actual Result.

What changes do you think we should make in order to solve the problem?

  1. We should add the correct website address (https://www.expensify.com) instead www.expensify.com in white list.
  2. If you don't want to open the expensify.com, we should change the pdfURL like following; ${CONFIG.EXPENSIFY.EXPENSIFY_URL} => ${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}
  3. We should prepare the pdf on backend side.

What alternative solutions did you explore? (Optional)

N/A

Contributor details

Your Expensify account email: anasup1995@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~01aff093c9a804b145

melvin-bot[bot] commented 1 week ago

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Christinadobrzyn commented 1 week ago

We're going to set this external to see if there are some suggestions to fix this. @dukenv0307 can you please review the proposal when you have a moment. Thank you!

dukenv0307 commented 1 week ago

I can't reproduce 2 last points

Tab with month statement is opened. Placeholder instead of info is displayed Statement is not downloaded New browser tab expensify.com is opened

@Anaslancer What about you?

Anaslancer commented 1 week ago

@dukenv0307 Strange, the pdf is downloaded now but didn't work 8 hours. And I think we should open ND in new tab. @lanitochka17 Is it right?

Anaslancer commented 1 week ago

When downloading we are using this url below; const pdfURL = ${CONFIG.EXPENSIFY.EXPENSIFY_URL}secure?secureType=pdfreport&filename=${fileName}&downloadName=${downloadFileName}; At the moment, if a user already logged in to OD in same browser, the new tab don't open and just download. If not, we open the OD in a new tab for getting the user's auth. For avoiding this (I mean for using the current user's auth of the ND), we can set ${CONFIG.EXPENSIFY.EXPENSIFY_URL} to ${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}. But ND has the same feature (creating a pdf and downloading) like OD.

Christinadobrzyn commented 4 days ago

@lanitochka17 might not be quick to respond as we usually communicate in Slack so let me know if I can help with relaying anything or if we should have QA test again.

lanitochka17 commented 4 days ago

@Christinadobrzyn tester is still reproducible issue

https://github.com/user-attachments/assets/bc8ed37a-00ee-4526-99aa-94778673398c

That might be the reason

image (13)

melvin-bot[bot] commented 4 days ago

@Christinadobrzyn, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Christinadobrzyn commented 3 days ago

ah interesting catch @lanitochka17 - testing again. I have a wallet setup in my test account c.dobrzyn+89@expensifail.com

and I see the statement isn't loading and nothing is downloaded. @dukenv0307 @Anaslancer can you test?

https://github.com/user-attachments/assets/3000dc72-c497-49a4-be84-947bd90c1e7a

Christinadobrzyn commented 2 days ago

nudge to @dukenv0307 or @Anaslancer can you test this again to make sure you can reproduce this?

melvin-bot[bot] commented 2 days ago

@Christinadobrzyn, @dukenv0307 Huh... This is 4 days overdue. Who can take care of this?

dukenv0307 commented 2 days ago

I'm trying to enable wallet. I just faced with the 666 BE error this morning

dukenv0307 commented 2 days ago

@Christinadobrzyn I found the thread that mentioned this problem: https://expensify.slack.com/archives/C01GTK53T8Q/p1723032105269869?thread_ts=1711049879.962529&cid=C01GTK53T8Q seems like we can't use the test wallet

We should make it internal

Christinadobrzyn commented 1 day ago

Ah thanks @dukenv0307 - changed this to internal. going back to this convo to see if someone has the bandwidth for this - https://expensify.slack.com/archives/C05LX9D6E07/p1731559170624659?thread_ts=1730884730.445159&cid=C05LX9D6E07

Christinadobrzyn commented 18 hours ago

looking for an internal volutneer