Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.89k forks source link

Offline comments in a thread room result in missing post and 'Access Denied' error upon reconnection #52179

Open brunovjk opened 1 week ago

brunovjk commented 1 week ago

Original GH: https://github.com/Expensify/App/issues/47708

Action Performed:

  1. Create a room that User A, User B, and User C are in.
  2. Post a comment as User A.
  3. Have User B go offline.
  4. Have User C create a thread on User A’s comment.
  5. While offline, have User B also create a thread on User A’s comment.
  6. Both User B and User C send messages in the thread.
  7. Bring User B back online.

Expected Result:

User B's and User C’s comments post in User A’s thread without any issues, and the Left-Hand Navigation updates accordingly.

Actual Result:

One response from the AddComment request after User B reconnects:

{
    "code": 666,
    "jsonCode": 666,
    "type": "Expensify\\Libs\\Error\\ExpError",
    "UUID": "E490CD6D-46BF-4EE2-8B4F-51672557284A",
    "message": "You don't have access to this chat room.",
    "title": "Room not accessible",
    "data": {
        "onyxData": [
            {
                "onyxMethod": "merge",
                "key": "reportActions_4167634506996915",
                "value": {
                    "8205893435296449884": {
                        "errors": {
                            "1729771507600209": "You don't have access to this chat room."
                        }
                    }
                }
            }
        ]
    },
    "htmlMessage": "",
    "onyxData": [
        {
            "onyxMethod": "merge",
            "key": "reportActions_4167634506996915",
            "value": {
                "8205893435296449884": {
                    "errors": {
                        "1729771507600209": "You don't have access to this chat room."
                    }
                }
            }
        }
    ],
    "requestID": "8d79d54f68183565-CNF"
}

Screenshots/Videos

image

cc: @AndrewGable

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @marcochavezf (AutoAssignerNewDotQuality)

marcochavezf commented 3 days ago

No update, I will look at this one this week