[$250] mweb - Per diem - View your subscription link opens Subscription page then back to Workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.59-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+zm27@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace
3. Go to More features
4. Enable Per diem
5. Tap Upgrade
6. On upgrade success screen, tap View your subscription

Expected Result:

App will open subscription page

Actual Result:

App opens subscription page and then opens workspace editor page quickly. This issue only happens when upgrading workspace to Control from Per diem feature

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Standalone
• [x] Android: HybridApp
• [x] Android: mWeb Chrome
• [ ] iOS: Standalone
• [x] iOS: HybridApp
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/bcdd8673-64a7-46ba-af35-d9ce8c50b4b1

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021854641998677095618
• Upwork Job ID: 1854641998677095618
• Last Price Increase: 2024-11-07

Issue Owner

Current Issue Owner: @ntdiary

[melvin-bot[bot]]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

💬 A slack conversation has been started in #expensify-open-source

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021854641998677095618

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[melvin-bot[bot]]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[carlosmiceli]

Wouldn't block deployment because it's a small issue that can be solved quickly.

[truph01]

Edited by proposal-police: This proposal was edited at 2024-11-08 03:00:25 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App opens subscription page and then opens workspace editor page quickly. This issue only happens when upgrading workspace to Control from Per diem feature

What is the root cause of that problem?

• Here we enable per diem, after enabling we are navigating the user to Workspace initial page: https://github.com/Expensify/App/blob/daf0addf17040ae0b0ad76e9705d20a7143b9a39/src/libs/actions/Policy/PerDiem.ts#L107-L109

What changes do you think we should make in order to solve the problem?

• We can pass a third parameter here disableRedirect = false: https://github.com/Expensify/App/blob/daf0addf17040ae0b0ad76e9705d20a7143b9a39/src/libs/actions/Policy/PerDiem.ts#L54 and update: https://github.com/Expensify/App/blob/daf0addf17040ae0b0ad76e9705d20a7143b9a39/src/libs/actions/Policy/PerDiem.ts#L107

    if (enabled && getIsNarrowLayout()  && !disableRedirect) {
        navigateWhenEnableFeature(policyID);
    }

and then we can pass true here as third param in:

https://github.com/Expensify/App/blob/daf0addf17040ae0b0ad76e9705d20a7143b9a39/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx#L84

What alternative solutions did you explore? (Optional)