search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.89k forks source link

[Workspace Feeds] RemoveFeed command fails #52252

Open mountiny opened 4 days ago

mountiny commented 4 days ago

Problem

Coming from here

When removing the company card feed, the RemoveFeed command fails with 404 Bank feed does not exist

Solution

Investigate why this is happening

melvin-bot[bot] commented 4 days ago

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

mountiny commented 4 days ago

Here are some logs https://www.expensify.com/_devportal/tools/logSearch/#sort=asc&size=10000&query=request_id%3A%228df583fe0b723bc4-WAW%22%20AND%20timestamp%3A%5B2024-11-08T00%3A00%20TO%202024-11-09T23%3A59%5D

mountiny commented 4 days ago

This is failing because the feed is pending so there is no CompanyID NVP for the feed. Gonna have to update that.

then the next thing is that the RemoveFeed command is not removing the feed from the comapnyCards settings in domain_member and it should

mountiny commented 2 days ago

Working on this one

mountiny commented 23 hours ago

PR in review

mountiny commented 14 hours ago

Merged