search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

GBR in the LHN for an expense that is in pending and have violation #52315

Open m-natarajan opened 5 days ago

m-natarajan commented 5 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: Reproducible in staging?: Needs reproduction Reproducible in production?: Needs Reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @quinthar Slack conversation (hyperlinked to channel name): ts_external_expensify_expense

Action Performed:

Prerequisite: Auto approval limit set for $1000 and Receipt required set for $200

  1. Submit a card expense for the amount above $1000 to approver
  2. As approver view the expense report

Expected Result:

RBR for the expense due to violation

Actual Result:

GBR in the LHN and violations displayed in expense details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

melvin-bot[bot] commented 5 days ago

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

MelvinBot commented 5 days ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

melvin-bot[bot] commented 1 day ago

@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

trjExpensify commented 1 day ago

@JmillsExpensify this feels like a similar consideration as when all expenses on the report are held and not showing the GBR to the approver in that case. Shall we progress this change independently, or do you want to wrap it up in that one with hold?

JmillsExpensify commented 1 day ago

this feels like a similar consideration as when all expenses on the report are held and not showing the GBR to the approver in that case

Yeah, agreed.

Shall we progress this change independently

Good question. It's probably better to do this centrally, I think.