Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

[$250] Critical: LHN says unavailable workspace #52388

Open m-natarajan opened 1 week ago

m-natarajan commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: Needs Reproducing Reproducible in production?: Needs Reproducing If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @heyjennahay Slack conversation (hyperlinked to channel name): ts_external_expensify_migrate

Action Performed:

Prerequisite: Login as a expelled member of workspace and paymant received for submitted expense

  1. Go to staging.new.expensify.com
  2. Observe the LHN
  3. Open the workspace to view the expenses

    Expected Result:

    The workspace chat is displayed as archived

    Actual Result:

    The workspace displayed as unavailable in LHN and refreshing the page resolves the issue

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

image (14)

{
    "chatType": "policyExpenseChat",
    "currency": "USD",
    "description": "",
    "errorFields": {},
    "hasOutstandingChildRequest": false,
    "hasOutstandingChildTask": false,
    "isCancelledIOU": false,
    "isOwnPolicyExpenseChat": true,
    "isPinned": true,
    "isWaitingOnBankAccount": false,
    "lastActionType": "REPORTPREVIEW",
    "lastActorAccountID": "2012843",
    "lastMessageHtml": "paid £199.04",
    "lastMessageText": "paid £199.04",
    "lastReadSequenceNumber": 0,
    "lastReadTime": "2024-11-11 22:07:48.215",
    "lastVisibleActionCreated": "2024-11-11 21:52:20.625",
    "lastVisibleActionLastModified": "2024-11-11 21:52:20.625",
    "managerID": 0,
    "nonReimbursableTotal": 0,
    "notificationPreference": "always",
    "oldPolicyName": "",
    "ownerAccountID": 2840332,
    "participants": {
        "2840332": {
            "hidden": false,
            "notificationPreference": "always"
        },
        "9645353": {
            "hidden": false,
            "notificationPreference": "always"
        },
        "10903701": {
            "hidden": false,
            "notificationPreference": "always"
        }
    },
    "permissions": [],
    "policyAvatar": "",
    "policyID": "A5F944A401046336",
    "policyName": "Expenses - Expensify UK",
    "private_isArchived": "",
    "reportID": "7246397494396164",
    "reportName": "Chat Report",
    "stateNum": 0,
    "statusNum": 0,
    "total": 0,
    "type": "chat",
    "unheldNonReimbursableTotal": 0,
    "unheldTotal": 0,
    "welcomeMessage": "",
    "writeCapability": "all"
}

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021856829046221721338
  • Upwork Job ID: 1856829046221721338
  • Last Price Increase: 2024-11-20
  • Automatic offers:
    • dominictb | Reviewer | 105008545
Issue OwnerCurrent Issue Owner: @dominictb
MelvinBot commented 1 week ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~021856829046221721338

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

puneetlath commented 1 week ago

The LHN says "unavailable workspace" part of this should be able to be handled externally. It seems to me to be a front-end issue.

I'm going to separate out the 404 receipts part of this.

flaviadefaria commented 3 days ago

@puneetlath I'll keep you assigned here as the BZ assignee but will look internally for someone to work on the backend part of this.

flaviadefaria commented 2 days ago

Updated this GH so that it only focuses on the "The LHN says 'unavailable workspace' part which can be handled externally.

mkzie2 commented 2 days ago

@puneetlath Can you also share the json data of policy that is related to the policy expense chat and the transaction data with receipt 404? It's helpful to find the RCA.

melvin-bot[bot] commented 1 day ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

pac-guerreiro commented 1 day ago

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

melvin-bot[bot] commented 20 hours ago

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

puneetlath commented 20 hours ago

Great. @pac-guerreiro you're going to specifically look into the "unavailable workspace" in the LHN, right? It's weird because in the report data shared, there is a policy name.

pac-guerreiro commented 12 hours ago

@puneetlath exactly! This one is interesting indeed 😅

My wild guess is that somewhere we're passing a null report or an object which is missing the policyName.

I'll need more data to find out the culprit 😄

Tomorow I'll let you know which data I need!