[$250] Workspace - No pending workspace join is shown via share link

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.60-0 Reproducible in staging?: Y Reproducible in production?: Y Issue was found when executing this PR: https://github.com/Expensify/App/pull/51631 Email or phone of affected tester (no customers): applausetester+bp2510@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Precondition: user A with a workspace.

1. User A: go to Settings > Workspaces > workspace > Profile
2. Click on Share > Copy URL
3. Send URL to user B, that is not a member of this ws
4. User B (logged in ND in mWeb): open URL in mobile browser

Expected Result:

List of workspaces opened. Workspace user B was sent a link has a label 'Requested'.

Actual Result:

Settings tab is opened. Sometimes, tap on Workspaces has no response. When open link again, user B is joined ws automatically.

Workaround:

Unknown

Platforms:

• [x] Android: Standalone
• [x] Android: HybridApp
• [x] Android: mWeb Chrome
• [ ] iOS: Standalone
• [ ] iOS: HybridApp
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/7fd5cffa-75cf-4c26-91a9-4fcde5afafd2

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021856489377948710082
• Upwork Job ID: 1856489377948710082
• Last Price Increase: 2024-11-13

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot[bot]]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021856489377948710082

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[ikevin127]

This is a tricky one as it seems to be Android (mWeb only ?) specific, possibly something navigation related because the logic below works as expected on all other platforms:

https://github.com/Expensify/App/blob/99da1ac87df0510567d93c8d7601f1c665ead485/src/pages/workspace/WorkspaceJoinUserPage.tsx#L29-L75

[Shahidullah-Muffakir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Requested badge is not showing in mobile devices

What is the root cause of that problem?

we are removing the requested badge in mobile devices here: https://github.com/Expensify/App/blob/99da1ac87df0510567d93c8d7601f1c665ead485/src/pages/workspace/WorkspacesListRow.tsx#L141

What changes do you think we should make in order to solve the problem?

if we want to show it in mobile devices remove the!shouldUseNarrowLayout

[Shahidullah-Muffakir]

[hoangzinh]

Hi @Shahidullah-Muffakir please note that it's not only "Requested badge" issue but also navigation issue in small screen devices. Can you retake a look?