Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #52419

Closed github-actions[bot] closed 6 days ago

github-actions[bot] commented 1 week ago

🚨 Failure Summary 🚨:

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named e2ePerformanceTests / Run E2E tests in AWS device farm. This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

  1. Why the PR caused the job to fail?
  2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

mountiny commented 1 week ago

Seems like it did not play that well because of the changed metrics but hopefully it will be fine on the next PRs

@adhorodyski @kirillzyusko @hannojg can you check if we need to do anything about these please?

adhorodyski commented 6 days ago

We need someone with access to the aws farm correct? Can I help in any way?

kirillzyusko commented 6 days ago

@mountiny I think it's expected failure, because we compare metrics with a previous commit. And since they were renamed - it's expected to have a crash in calculation, because we expect, that names in main/delta are the same.

I think subsequent runs (for next merged PRs) were successful? If so, then I think we can close this issue 🙂

mountiny commented 6 days ago

Yep sounds right to me