Open m-natarajan opened 2 weeks ago
Triggered auto assignment to @deetergp (AutoAssignerNewDotQuality
)
Triggered auto assignment to @trjExpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
@deetergp I'm assuming notification issues like this need to remain internal, but let me know if you don't think so and we can ask a C+ to get involved as a next step to try and reproduce.
I seemingly can't repro this myself. Question from the thread is: "Why isn't the ping/ping detecting and fixing this?"
This happened again; I can't figure out how to reproduce reliably though.
@deetergp, @trjExpensify Huh... This is 4 days overdue. Who can take care of this?
@deetergp thoughts on the above, will you be able to look at this today?
CC: @muttmuure I think this one is in the CRITICAL category for #quality, so I've moved it there.
Great!
On Mon, 18 Nov 2024 at 11:35, Tom Rhys Jones @.***> wrote:
@deetergp https://github.com/deetergp thoughts on the above, will you be able to look at this today?
CC: @muttmuure https://github.com/muttmuure I think this one is in the CRITICAL category for #quality, so I've moved it there.
— Reply to this email directly, view it on GitHub https://github.com/Expensify/App/issues/52437#issuecomment-2482786721, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALGRREHAPCVDK6DGO5NCLVT2BHGI7AVCNFSM6AAAAABRVGUUOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBSG44DMNZSGE . You are receiving this because you were mentioned.Message ID: @.***>
@trjExpensify I've spent a bit of time with this today and I also cannot seem to reproduce it. I've been having a protracted conversation between the ExpensiScotts (-fy.com & -fail.com) in splitscreen browser windows and they both come through fine. I'm looking at DM chat between DB & Kadie to see if there's anything "off" about what's in Auth and in the logs.
Gotcha. I'm sure DB would be happy to live debug or something, if you want to take it to the thread: https://expensify.slack.com/archives/C05LX9D6E07/p1731449676200089?thread_ts=1731299637.345689&cid=C05LX9D6E07
@deetergp, @trjExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
Spent a bit of time looking into this today and it interesting. A log search for blob:"PusherError"
returns tens of thousands of results for just the last 24 hours. They all have the 1006 error code which Pusher's documentation has this to say about it:
When a WebSocket connection is closed without a "close frame", the pusher-js library emits an error with code 1006. Usually this is caused by WebSocket-incompatible proxies, which can't close the connection in the correct way.
Looking specifically into @quinthar's logs, I see an interesting 1006
log line that pops up: Software caused connection abort
. Between my own searching and ChatGPT, it sounds like poor network connectivity can be a culprit, as can "Version or Library Mismatch". I found some GH issues from 2021 that talk about needing to be on the latest (for the time) version of 9.x. Looking in our package.json file, it looks like we are on v 8.3.0. Maybe we need to update the version of the pusher client we are using?
I'm not sure how involved updating to a newer version might be, maybe @mountiny or @AndrewGable might have some insight?
@deetergp @trjExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@deetergp I dont know the specifics it would involve to update the pusher, but here is a PR when we did it last time and seems like it was fine without any specific testing and it was fine. So I would check if there are any specific breaking changes that should worry us and try to update it. However, we are already on the latest officially stable version 8.3.0 https://www.npmjs.com/package/pusher-js?activeTab=versions the next version 8.4.0 is still a release candidate.
Hmm… Maybe I'm confusing versions of other things. @quinthar Does this happen when you're using a poor connectivity setting in Dev Tools? Just trying to narrow down possible causes…
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @quinthar Slack conversation (hyperlinked to channel name): ts_external_expensify_quality
Action Performed:
Expected Result:
User A receives message in real time
Actual Result:
For user A typing indicator displayed, not receiving realtime updates to desktop/web session, but receiving push notifications in mobile for the same
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/7b474301-da0e-40c3-b26a-188569db9537
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @deetergp