Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.9k forks source link

Web - Pay someone-Wallet page displayed in central pane instead of 1:1 chat after validating account #52456

Open IuliiaHerets opened 1 day ago

IuliiaHerets commented 1 day ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.61.0 Reproducible in staging?: Y Reproducible in production?: Not repro in Prod, App logging out Issue was found when executing this PR: https://github.com/Expensify/App/pull/50835 Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/ and log in with a new account
  2. Select Something else on the onboarding modal
  3. Click on FAB > Start chat and enter an email of another user
  4. In 1:1 chat click on + > Pay someone
  5. Enter the amount and proceed to the next step
  6. Select Pay with Expensify
  7. Enter correct code

Expected Result:

1:1 chat is still displayed in the central pane

Actual Result:

Wallet page is displayed in the central pane instead of 1:1 chat

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/9677e09e-7e6d-43b2-883a-7c7d0dfbf8be

View all open jobs on GitHub

melvin-bot[bot] commented 1 day ago

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 day ago

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 day ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 1 day ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
IuliiaHerets commented 1 day ago

Production has the following behaviour

https://github.com/user-attachments/assets/e673807c-c8ba-4798-8aa8-a8fda311fe35

Nodebrute commented 1 day ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pay someone-Wallet page displayed in central pane instead of 1:1 chat after validating account

What is the root cause of that problem?

We are not passing backTo route here https://github.com/Expensify/App/blob/4d9be4eb2537b49fa6cf35135770cf3c6d62a1cd/src/components/SettlementButton/index.tsx#L194

What changes do you think we should make in order to solve the problem?

We should add backTo route here. We can do something like this here

 if (!isUserValidated) {
                const activeRoute = Navigation.getActiveRoute();
                Navigation.navigate(ROUTES.SETTINGS_WALLET_VERIFY_ACCOUNT.getRoute(activeRoute));
                return;
            }

What alternative solutions did you explore? (Optional)

arosiclair commented 1 day ago

Let's not block on this since it's not really a regression. I'll take over and make sure this gets cleaned up.

arosiclair commented 11 hours ago

This should be simple to fix so I'll do it internally