[HOLD for payment 2024-11-22] [$250] Web - Concierge - Onboarding tasks in Concierge chat is duplicated when switch chat

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.62-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5222784&group_by=cases:section_id&group_order=asc&group_id=229043 Email or phone of affected tester (no customers): gocemate+a2824@gmail.com Issue reported by: Applause Internal Team

Action Performed:

1. Create a new gmail user
2. Verify that the "What do you want to do today?" modal appears
3. Select the purpose "Chat and split expenses with friends"
4. Click on "Continue"
5. Verify that the "What’s your name?" modal appears
6. Enter any names
7. Click on "Continue"
8. Close the video modal
9. Open the Concierge chat
10. Verify that the app has generated a welcome message and onboarding tasks in Concierge chat
11. Open the Concierge chat again

Expected Result:

A welcome message and onboarding tasks in Concierge chat should be present

Actual Result:

A welcome message and onboarding tasks in Concierge chat is duplicated when switch chat

Workaround:

Unknown

Platforms:

• [ ] Android: Standalone
• [ ] Android: HybridApp
• [ ] Android: mWeb Chrome
• [ ] iOS: Standalone
• [ ] iOS: HybridApp
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/9feee508-5b83-418f-9ef6-fe617df7c517

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021857103016023822782
• Upwork Job ID: 1857103016023822782
• Last Price Increase: 2024-11-14
• Automatic offers:
• allgandalf | Contributor | 104901467

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot[bot]]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

💬 A slack conversation has been started in #expensify-open-source

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[twisterdotcom]

Agree, I recreated this. It's very odd to see it twice. We only complete CompleteGuidedSetup once, so I don't understand why navigating back to chat shows it twice.

https://github.com/user-attachments/assets/d9cb79d9-125b-4bb6-8026-7790a73b4cae

I think this one should be Hourly and block the deploy.

[twisterdotcom]

Posted in Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1731589469103229?thread_ts=1731582255.236159&cid=C01GTK53T8Q

Not sure how best to continue helping here. @Gonals lmk if you have any ideas, otherwise we can get some External eyes and pay out for it.

[NJ-2020]

Offending PR: https://github.com/Expensify/App/pull/46052

[blazejkustra]

Offending PR: #46052

I worked on it, so taking a look now 👀

[NJ-2020]

Specifically this code causes this issue

[Gonals]

@blazejkustra, thanks! Keep me posted!

[blazejkustra]

Sure! I might have a fix today, I'll update in max 2h

[Gonals]

Neat. This is a deploy blocker (and today is Thursday), so we pretty much need a fix today. Let me know if you can't prioritize this and I'll find someone/do it myself

[Gonals]

(or we can revert the PR that caused it if we can't figure out a fix today)

[Gonals]

cc @francoisl

[blazejkustra]

I think I have a fix, will post a PR and do more testing in a moment! cc @Gonals

https://github.com/user-attachments/assets/b124c69b-5f4c-4d1d-97ed-4276efe760d3

[blazejkustra]

@Gonals PR is ready for review https://github.com/Expensify/App/pull/52585

The problem was that we generated onboarding messages twice, first for onboarding flow and then first time a report was opened. Now we check NVP_ONBOARDING so that messages are never duplicated.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021857103016023822782

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot[bot]]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[Gonals]

@allgandalf will be reviewing this PR! @blazejkustra has a fix ready 😁

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.62-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/52585

If no regressions arise, payment will be issued on 2024-11-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)
• @allgandalf requires payment automatic offer (Contributor)

[melvin-bot[bot]]

@allgandalf @twisterdotcom @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[allgandalf]

I guess only payment here, Do we need a checklist here ? it was a deploy blocker, let me know if needed