search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.59k stars 2.92k forks source link

RBR doesn't display immediately when a receipt with a modified amount is submitted #52557

Closed IuliiaHerets closed 2 weeks ago

IuliiaHerets commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.62-2 Reproducible in staging?: Y Reproducible in production?: N Issue was found when executing this PR: https://github.com/Expensify/App/pull/52478 Email or phone of affected tester (no customers): applausetester+bm231@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Preconditions:

  1. Navigate to the workspace chat.
  2. Scan a receipt and wait until scanning completes.
  3. Open the preview and modify the amount.
  4. Return to the main chat and click the Submit button.

Expected Result:

The RBR should appear immediately.

Actual Result:

The RBR does not appear, even when navigating to another chat and returning. It only reappears after opening the expense and then returning back.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/71c897e5-9336-4d86-ba33-26e68018446f

View all open jobs on GitHub

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 weeks ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 2 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
Nodebrute commented 2 weeks ago

offending pr https://github.com/Expensify/App/pull/52478

dangrous commented 2 weeks ago

oh no does that mean we're going to have to revert a revert of a revert

iwiznia commented 2 weeks ago

Looking into this

iwiznia commented 2 weeks ago

Context https://expensify.slack.com/archives/C03TQ48KC/p1731601123347109?thread_ts=1731598521.545959&cid=C03TQ48KC

francoisl commented 2 weeks ago

So now the RBR appears immediately after you upload the receipt, while it's still scanning. Is that expected?

image
kavimuru commented 2 weeks ago

Not reproducible

https://github.com/user-attachments/assets/e8a2e7c5-82a3-4466-9c60-2d073f466124

iwiznia commented 2 weeks ago

Nice the fix worked then