[HOLD for payment 2024-11-22] Expense - The app crashes when deleting an error about creating a distance expense

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.62-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5222476 Email or phone of affected tester (no customers): sustinov@applausemail.com Issue reported by: Applause Internal Team

Action Performed:

1. Open New Expensify app
2. Log in with a new HT account
3. Create a WS
4. Go to the WS room
5. Disconnect the internet
6. Click + Menu > Submit expense
7. Select Distance option
8. Enter a vague start location, random characters should also work
9. Enter a vague finish location, random characters should also work
10. Finish the submit creation flow
11. Turn on the internet
12. Remove the distance expense creation error

Expected Result:

If the error about creating a distance expense is cleared, the application should crash.

Actual Result:

The app crashes when deleting an error about creating a distance expense

Workaround:

Unknown

Platforms:

• [ ] Android: Standalone
• [ ] Android: HybridApp
• [x] Android: mWeb Chrome
• [ ] iOS: Standalone
• [ ] iOS: HybridApp
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/a50a11aa-e287-4f70-8124-563bc6135aff

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot[bot]]

Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot[bot]]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Nodebrute]

same rca as https://github.com/Expensify/App/issues/52542

[allgandalf]

This will be fixed in https://github.com/Expensify/App/pull/52547

[mountiny]

@allgandalf, can you please link this issue to your PR and include tests for this so QA can confirm once CPed?

[allgandalf]

Done updated @mountiny

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[allgandalf]

@puneetlath this was fixed in https://github.com/Expensify/App/pull/52547, please ask QA to retest and close this issue, thanks !

[puneetlath]

Yep, asked.

[kavimuru]

Not reproducible in 9.0.62-4

https://github.com/user-attachments/assets/7cb6b1ec-b461-41a6-afd6-c8fe8b0e74b5

[puneetlath]

Great, thanks!

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.62-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/52547

If no regressions arise, payment will be issued on 2024-11-22. :confetti_ball:

[melvin-bot[bot]]

@puneetlath / @johnmlee101 @puneetlath @puneetlath / @johnmlee101 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]