Android - Hybrid - Profile - Phone number gets deleted everytime the user logs out

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.62-0 Reproducible in staging?: N Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5226370&group_by=cases:section_id&group_order=asc&group_id=229064 Issue reported by: Applause Internal Team

Action Performed:

1. Open the Expensify app.
2. Tap on "Settings" on the bottom of the page.
3. Tap on "Profile"
4. Scroll down to "Phone Number" and tap on it.
5. Complete with a valid phone number and tap on save. 6 Log out of the account.
6. Log in to the same account again.
7. Tap on "Settings" on the bottom of the page.
8. Tap on "Profile"
9. Verify that phone number field displays the saved information.

Expected Result:

Information in phone number, should remain the same after logging out and logging in to the account again.

Actual Result:

Phone number gets deleted after the user logs out and logs in again to the account.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Standalone
• [x] Android: HybridApp
• [ ] Android: mWeb Chrome
• [ ] iOS: Standalone
• [ ] iOS: HybridApp
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/668918a3-3728-4283-8b44-2de163697984

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

💬 A slack conversation has been started in #expensify-open-source

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

I marked it as a deploy, as in the hybrid prod app no options for phone number at all

https://github.com/user-attachments/assets/3c3e2dc8-b630-4b66-9926-d2a77d575fef

[NikkiWines]

Hmm, I don't see anything on the most recent deploy that would be tied to this 🤔

Logs don't show anything awry either

[NikkiWines]

We added the phone number to private personal details 2 weeks ago in [Feature]: Add phone number to the private personal details section (# 50773 (Avoiding tagging cause it's not necessarily the cause here)) but it's live for a couple weeks at least. Nothing has changed in the logic around that code since afaict

If this isn't available on prod yet, I think it's just HybridApp is a few versions behind and so it's not actually a blocker.

But also cc: @allgandalf @mountiny since this seems like it might not be working at 100%

[allgandalf]

well well, ~The thing here must be openApp is not returning phone number for privatePersonalDetails~, this was reported I guess , but it must have been slipped through the cracks. ~@NikkiWines can you check on the backend if we return phone number please~

Everything works great for standalone ND

[allgandalf]

Or on hybrid app can you ask the tested to update any of the private fields, like legal name, if the number reappears after we change legal name then it has to be the openApp call not including phone number

[allgandalf]

If this isn't available on prod yet, I think it's just HybridApp is a few versions behind and so it's not actually a blocker.

This might be the case @NikkiWines , on ND standalone, this is not reproducible

[NikkiWines]

Yeah, it's a hybrid app only issue currrently.

I see we return PRIVATE_PERSONAL_DETAILS in ReconnectApp, and GetMissingOnyxMessages, but not specifically in OpenApp. But... we do return it in OpenPersonalDetailsPage so it should be updated regardless when the user goes to look at their details 🤔

[mountiny]

OpenApp is just calling full reconnect, right? I have tested that it returned here https://github.com/Expensify/Auth/pull/13129 and it was deployed couple hours back

[mountiny]

Seems odd, could it be that they signed out before the write request could be completed 🤔 I would not block on this if you cannot reproduce elsewhere

[mountiny]

Just tested on ios hybrid app staging and its working 🎉 so yeah I would demote and try to retest later

[NikkiWines]

Thanks for double checking @mountiny 🙇

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989