Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.58k stars 2.92k forks source link

iOS - Expense - Submit button is gone briefly after merchant editor is dismissed on confirm page #52592

Open lanitochka17 opened 1 week ago

lanitochka17 commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.62-3 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+w8@applause.expensifail.com Issue reported by: Applause - Internal Team

Issue found when executing PR https://github.com/Expensify/App/pull/51318

Action Performed:

  1. Launch ND app
  2. Go to FAB > Submit expense
  3. Enter amount > Next
  4. Select a workspace
  5. Tap Merchant
  6. Enter merchant and save it

Expected Result:

Submit button will appear at the bottom as soon as the merchant editor is dismissed

Actual Result:

Submit button is gone briefly after merchant editor is dismissed on confirmation page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/3752ac64-f9ff-49b7-a57c-3aee04cdbe52

View all open jobs on GitHub

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 week ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
aldo-expensify commented 1 week ago

I'm not being able to reproduce using my Mac:

https://github.com/user-attachments/assets/c3e9b83d-6225-477d-9df0-87d292c40af8

From the video in the issue, it appears to be some performance issue. The flickering of the button is always there, including production, but it should be much faster than what we see in the video.

I'll try to reproduce in my phone.

aldo-expensify commented 1 week ago

I'll try to reproduce in my phone.

The button takes longer to appear in Android native using the staging app, but I guess that is somewhat expected since it is much slower than my mac/web. I'll try to test Android native using the production app to see if there is a difference between staging/production.

lanitochka17 commented 1 week ago

Sorry for confusion, This issue repro on IOS and not repro in Android

aldo-expensify commented 1 week ago

Can't reproduce in dev using the IOS emulator, the button appears instantly

https://github.com/user-attachments/assets/d40567ac-e4d7-438e-b840-fb61264956cf

I'll remove the DeployBlockerCash label since I can't reproduce and Jayesh wasn't able to reproduce either: https://expensify.slack.com/archives/C02NK2DQWUX/p1731615988446309?thread_ts=1731615180.163839&cid=C02NK2DQWUX

Maybe the device used was very slow (old?)?

MelvinBot commented 1 week ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

aldo-expensify commented 1 day ago

I just noticed I should have added retest-weekly together with Needs reproduction