Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.9k forks source link

Group chat - New member is displayed with offline profile avatar #52639

Open IuliiaHerets opened 2 hours ago

IuliiaHerets commented 2 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.63-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5229966&group_by=cases:section_id&group_id=296760&group_order=asc Email or phone of affected tester (no customers): gocemate+a2862@gmail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Create group conversation with few members
  2. Click on header> Members> Invite new member
  3. Enter email address and take a look at user's avatar

Expected Result:

User should have default or custom profile avatar

Actual Result:

User is displayed with offline profile avatar when invite it in existing group chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/960c7f37-ca6f-4151-9804-eb5ce6428d4c

View all open jobs on GitHub

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

gijoe0295 commented 2 hours ago

Edited by proposal-police: This proposal was edited at 2024-11-15 18:12:12 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is displayed with offline profile avatar when invite it in existing group chat

What is the root cause of that problem?

In NewChatPage, we retrieved the personal details data, specifically avatar, from the BE through SearchForReport API.

But in InviteReportParticipantsPage, we only get the details from Onyx.

What changes do you think we should make in order to solve the problem?

In InviteReportParticipantsPage, call SearchForReport same as RoomInvitePage:

https://github.com/Expensify/App/blob/c3c7c7ac2c7d844463536c403064b58051add579/src/pages/RoomInvitePage.tsx#L238-L241

https://github.com/Expensify/App/blob/c3c7c7ac2c7d844463536c403064b58051add579/src/pages/InviteReportParticipantsPage.tsx#L58-L60

Report.searchInServer(debouncedSearchTerm);