search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.59k stars 2.92k forks source link

Investigate useOnyx infinite loading state related to the Connection Manager #52640

Open fabioh8010 opened 2 weeks ago

fabioh8010 commented 2 weeks ago

This issue was first noticed here -> https://github.com/Expensify/App/pull/49509.

I recently implemented a fix in Onyx to solve the infinite loading states after a Onyx.clear() operation, but in this case they are happening without the clear operation, so we must investigate it again.

Report of the problem: https://github.com/Expensify/App/pull/49509#issuecomment-2462699104 Reproducible steps: https://github.com/Expensify/App/pull/49509#issuecomment-2403667996 My initial investigations: https://github.com/Expensify/App/pull/49509#issuecomment-2477373813

fabioh8010 commented 6 days ago

Hi @gijoe0295 Could you confirm for me if you are still being able to reproduce this loading state issue? I'm having difficulties to reproduce it. If you are able could you give me the detailed test steps again? Thanks

fabioh8010 commented 4 days ago

@ishpaul777 maybe you can help me here with reproducing the problem from your side? We need to remove reuseConnection: false from src/pages/workspace/withPolicy.tsx before testing.

ishpaul777 commented 4 days ago

I'll check a confirm in few hours

ishpaul777 commented 1 day ago

Tried multiple times, no luck reproducing this is resolved mysteriously

https://github.com/user-attachments/assets/560aa9b8-a4bd-4c2c-824d-7ace767a8829