Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

Held expense - Empty message with reply appears after paying the unheld amount for second time #52696

Open IuliiaHerets opened 2 hours ago

IuliiaHerets commented 2 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.63-3 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): applausetester+kh051115@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. [User A] Submit two expenses to User B.
  3. [User B] Hold the first expense.
  4. [User B] Click Pay button and pay the unheld amount.
  5. [User A] Submit another expense to User B.
  6. [User B] Go to the expense report.
  7. [User B] Click Pay button and pay the unheld amount.
  8. [User B] Note that the held expense is marked as paid when it should be moved to another report.
  9. [User B] Refresh the expense report.
  10. [User B] Note that there is an empty message with reply which opens the held expense when clicked.

Expected Result:

In Step 8, the held expense should move to another report when only the pending amount is paid. In Step 10, after refreshing the page, there should not be an empty message in the expense report.

Actual Result:

In Step 8, the held expense does not move to another report when only the pending amount is paid. The expense preview is marked as paid when only the unheld amount is paid.

In Step 10, after refreshing the page, there is an empty message in the expense report, which opens the held expense.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/30edbfda-f5d2-4387-907c-77893225d3d2

Bug6668237_1731920941852!bandicam_2024-11-18_17-01-57-378

View all open jobs on GitHub

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.