Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

Travel-The Book Travel modal is not displayed after accepting the terms and conditions #52722

Open IuliiaHerets opened 2 hours ago

IuliiaHerets commented 2 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:v9.0.63-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5230078 Issue reported by: Applause Internal Team

Action Performed:

Setup:

  1. Login with new expensifail account
  2. Create a workspace
  3. Run the snippet: NVP.set('travelSettings', {'testAccount': true});
  4. Set the following Company Address "548 Market St San Francisco, CA 94104, United States"

Steps:

  1. Log in to NewDot Staging with the expensifail account created in Setup
  2. Click on FAB button
  3. Click on "Book Travel"
  4. Verify a modal opens with a brief information on the feature
  5. Click on "Book Travel" button
  6. Verify the user is prompted to accept the terms and conditions
  7. Check the box and continue
  8. Verify the user is navigated - back to the Book Travel modal

Expected Result:

The user is navigated - back to the Book Travel modal.

Actual Result:

The user is navigated to http://travel.expensify.com/ in a new tab instead of back to the Book Travel modal.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/a760d8fc-ab17-4da0-a22b-7125ba118b69

View all open jobs on GitHub

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.