Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.58k stars 2.92k forks source link

[$50] Update copy on the wallet settings page #52789

Open tgolen opened 6 days ago

tgolen commented 6 days ago

Problem

When users find it difficult to navigate our application's features due to interface clutter, it leads to decreased engagement and lower conversion and retention rates.

Solution

Clean up some of the copy on the wallet settings page:

  1. Change the title of the block from "Send and receive money with friends" to "Expensify Wallet"
  2. Change the subtitle from "Your wallet has been enabled to send and receive money with friends." to "Send and receive money with friends."

image

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021859017641475961132
  • Upwork Job ID: 1859017641475961132
  • Last Price Increase: 2024-11-19
  • Automatic offers:
    • rayane-djouah | Reviewer | 105008734
Issue OwnerCurrent Issue Owner: @rayane-djouah
melvin-bot[bot] commented 6 days ago

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

nkdengineer commented 6 days ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update copy on the wallet settings page

What is the root cause of that problem?

This is an improvment

What changes do you think we should make in order to solve the problem?

Change this translation to Expense Wallet and

https://github.com/Expensify/App/blob/763215e0aa0ac256f5f129e7f62444a466e84e8f/src/languages/en.ts#L1410

change this to Send and receive money with friends. https://github.com/Expensify/App/blob/763215e0aa0ac256f5f129e7f62444a466e84e8f/src/languages/en.ts#L1412

We also need to update the translation in es.ts file accordingly

What alternative solutions did you explore? (Optional)

trjExpensify commented 6 days ago

@tgolen did you want to send this external? If so, I think we reduce the price quite considerably to say $50 for a small copy change.

tgolen commented 6 days ago

I think a reduced price makes a lot of sense!

melvin-bot[bot] commented 6 days ago

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

melvin-bot[bot] commented 6 days ago

Job added to Upwork: https://www.upwork.com/jobs/~021859017641475961132

melvin-bot[bot] commented 6 days ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

trjExpensify commented 6 days ago

https://www.upwork.com/jobs/~021859017641475961132

Done!

hungdannt commented 6 days ago

Contributor details Your Expensify account email: caucahotran@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~0199da86ff25cda0b3

melvin-bot[bot] commented 6 days ago

πŸ“£ @hungdannt! πŸ“£ Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
hunghinh2000 commented 5 days ago

Contributor details Your Expensify account email: hunghinh2000vn@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~01a2a6c6ca80bc50fa

melvin-bot[bot] commented 5 days ago

βœ… Contributor details stored successfully. Thank you for contributing to Expensify!

hunghinh2000 commented 5 days ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Users find it difficult to navigate the wallet settings page due to cluttered interface copy.

What is the root cause of that problem?

The current wallet section title and subtitle are overly verbose and redundant.

What changes do you think we should make in order to solve the problem?

Update translations in src/languages/en.ts:

walletPage: {
    sendAndReceiveMoney: 'Expensify Wallet', // Changed from "Send and receive money with friends"
    walletEnabledToSendAndReceiveMoney: 'Send and receive money with friends', // Changed from "Your wallet has been enabled to send and receive money with friends"
}

What alternative solutions did you explore? (Optional)

prakashbask commented 5 days ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clean up some of the copy on the wallet settings page:

What is the root cause of that problem?

UX improvement suggestion to reduce interface clutter and improve customer engagement and retention

What changes do you think we should make in order to solve the problem?

1) To change the title of the block from "Send and receive money with friends" to "Expensify Wallet", change title to use title={translate('walletPage.expensifyWallet')}. walletPage.expensifyWallet is already defined in the language translation files. The change will be done at

https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/pages/settings/Wallet/WalletPage/WalletPage.tsx#L402 2) To change the subtitle from "Your wallet has been enabled to send and receive money with friends." to "Send and receive money with friends.", change subtitle to use subtitle={translate('walletPage.sendAndReceiveMoney'')}. The conditional check of hasActivatedWallet to display text will be removed at the following location https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/pages/settings/Wallet/WalletPage/WalletPage.tsx#L401 3) Remove all language translations for enableWalletToSendAndReceiveMoney and walletEnabledToSendAndReceiveMoney at https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/languages/en.ts#L1411 https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/languages/en.ts#L1412 https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/languages/es.ts#L1412 https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/languages/es.ts#L1413

End Result is Screenshot 2024-11-20 at 8 01 24 PM

What alternative solutions did you explore? (Optional)

The current solution assumes that the title and subtitle for Wallet section remains the same in both activated and non-activated condition. If we need to display different title and subtitle based on activated/non-activated check then following changes will be required subtitle={translate(`walletPage.${hasActivatedWallet ? 'sendAndReceiveMoney' : 'enableWalletToSendAndReceiveMoney'}`)} title={translate(`walletPage.${hasActivatedWallet ? 'expensifyWallet' : 'sendAndReceiveMoney'}`)}

rayane-djouah commented 5 days ago

@tgolen @trjExpensify - In the case where the wallet is not enabled, I think we need to update the title from Send and receive money with friends to Expensify Wallet and keep the current subtitle (Enable your wallet to send and receive money with friends.), right? Or should we change Enable your wallet to send and receive money with friends. to Send and receive money with friends?

Screenshot 2024-11-20 at 10 36 39β€―PM
trjExpensify commented 5 days ago

Hm, I don't like changing the title personally. I would think we just have this in both pre/post-enablement states?

Expensify Wallet Send and receive money with friends.

rayane-djouah commented 5 days ago

Agreed, having this in both pre/post-enablement states makes sense for consistency. Thanks!

rayane-djouah commented 5 days ago

@prakashbask's proposal looks good to me.

:ribbon::eyes::ribbon: C+ reviewed

melvin-bot[bot] commented 5 days ago

Current assignee @tgolen is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

melvin-bot[bot] commented 4 days ago

πŸ“£ @rayane-djouah πŸŽ‰ An offer has been automatically sent to your Upwork account for the Reviewer role πŸŽ‰ Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] commented 4 days ago

πŸ“£ @prakashbask You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review πŸ§‘β€πŸ’» Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing πŸ“–

prakashbask commented 4 days ago

I have applied to the job on Upwork and target to have the PR ready by 22-Nov

prakashbask commented 4 days ago

PR #52942