Open tgolen opened 6 days ago
Triggered auto assignment to @trjExpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Update copy on the wallet settings page
This is an improvment
Change this translation to Expense Wallet
and
change this to Send and receive money with friends.
https://github.com/Expensify/App/blob/763215e0aa0ac256f5f129e7f62444a466e84e8f/src/languages/en.ts#L1412
We also need to update the translation in es.ts file accordingly
@tgolen did you want to send this external? If so, I think we reduce the price quite considerably to say $50 for a small copy change.
I think a reduced price makes a lot of sense!
β οΈ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.
Job added to Upwork: https://www.upwork.com/jobs/~021859017641475961132
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External
)
Contributor details Your Expensify account email: caucahotran@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~0199da86ff25cda0b3
π£ @hungdannt! π£ Hey, it seems we donβt have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Contributor details Your Expensify account email: hunghinh2000vn@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~01a2a6c6ca80bc50fa
β Contributor details stored successfully. Thank you for contributing to Expensify!
Users find it difficult to navigate the wallet settings page due to cluttered interface copy.
The current wallet section title and subtitle are overly verbose and redundant.
Update translations in src/languages/en.ts
:
walletPage: {
sendAndReceiveMoney: 'Expensify Wallet', // Changed from "Send and receive money with friends"
walletEnabledToSendAndReceiveMoney: 'Send and receive money with friends', // Changed from "Your wallet has been enabled to send and receive money with friends"
}
Clean up some of the copy on the wallet settings page:
UX improvement suggestion to reduce interface clutter and improve customer engagement and retention
1) To change the title of the block from "Send and receive money with friends" to "Expensify Wallet", change title to use
title={translate('walletPage.expensifyWallet')}
. walletPage.expensifyWallet is already defined in the language translation files. The change will be done at
https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/pages/settings/Wallet/WalletPage/WalletPage.tsx#L402 2) To change the subtitle from "Your wallet has been enabled to send and receive money with friends." to "Send and receive money with friends.", change subtitle to use
subtitle={translate('walletPage.sendAndReceiveMoney'')}
. The conditional check of hasActivatedWallet to display text will be removed at the following location https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/pages/settings/Wallet/WalletPage/WalletPage.tsx#L401 3) Remove all language translations for enableWalletToSendAndReceiveMoney and walletEnabledToSendAndReceiveMoney at https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/languages/en.ts#L1411 https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/languages/en.ts#L1412 https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/languages/es.ts#L1412 https://github.com/Expensify/App/blob/9f83a4118ff0b8080ac8c037b36a26252a12b06f/src/languages/es.ts#L1413
End Result is
The current solution assumes that the title and subtitle for Wallet section remains the same in both activated and non-activated condition.
If we need to display different title and subtitle based on activated/non-activated check then following changes will be required
subtitle={translate(`walletPage.${hasActivatedWallet ? 'sendAndReceiveMoney' : 'enableWalletToSendAndReceiveMoney'}`)}
title={translate(`walletPage.${hasActivatedWallet ? 'expensifyWallet' : 'sendAndReceiveMoney'}`)}
@tgolen @trjExpensify - In the case where the wallet is not enabled, I think we need to update the title from Send and receive money with friends
to Expensify Wallet
and keep the current subtitle (Enable your wallet to send and receive money with friends.
), right? Or should we change Enable your wallet to send and receive money with friends.
to Send and receive money with friends
?
Hm, I don't like changing the title personally. I would think we just have this in both pre/post-enablement states?
Expensify Wallet Send and receive money with friends.
Agreed, having this in both pre/post-enablement states makes sense for consistency. Thanks!
@prakashbask's proposal looks good to me.
:ribbon::eyes::ribbon: C+ reviewed
Current assignee @tgolen is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.
π£ @rayane-djouah π An offer has been automatically sent to your Upwork account for the Reviewer role π Thanks for contributing to the Expensify app!
π£ @prakashbask You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing π
I have applied to the job on Upwork and target to have the PR ready by 22-Nov
PR #52942
Problem
When users find it difficult to navigate our application's features due to interface clutter, it leads to decreased engagement and lower conversion and retention rates.
Solution
Clean up some of the copy on the wallet settings page:
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @rayane-djouah