Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.92k forks source link

Accounting task instruction update #52808

Closed trjExpensify closed 5 days ago

trjExpensify commented 5 days ago

Explanation of Change

I missed this one because the instruction was "Click your profile photo" not "Click your profile picture" like the other tasks, so I didn't find it when doing a look up to replace them in the OG PR.

Fixed Issues

$ https://github.com/Expensify/App/issues/52760

Tests

None

Offline tests

None

QA Steps

It's just a copy change, but you can see these tasks with the following steps:

  1. Sign-up for a new account on new.expensify.com
  2. Choose "Manage my team's expenses"
  3. Choose Quickbooks Online on the accounting step
  4. Navigate to the Concierge DM
  5. Click into the "Connect to QuickBooks Online" task
  6. Verify the first numbered step in the copy reads "Click the settings tab" not "Click your profile photo."

PR Author Checklist

Screenshots/Videos

None

melvin-bot[bot] commented 5 days ago

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny commented 5 days ago

Reviewer Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
OSBotify commented 5 days ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions[bot] commented 4 days ago

πŸš€ Deployed to staging by https://github.com/mountiny in version: 9.0.65-0 πŸš€

platform result
πŸ€– android πŸ€– success βœ…
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ success βœ…
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ success βœ…
github-actions[bot] commented 3 days ago

πŸš€ Deployed to production by https://github.com/chiragsalian in version: 9.0.65-5 πŸš€

platform result
πŸ€– android πŸ€– success βœ…
πŸ–₯ desktop πŸ–₯ success βœ…
🍎 iOS 🍎 success βœ…
πŸ•Έ web πŸ•Έ success βœ…
πŸ€–πŸ”„ android HybridApp πŸ€–πŸ”„ failure ❌
πŸŽπŸ”„ iOS HybridApp πŸŽπŸ”„ failure ❌