Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.92k forks source link

fix: Taxes - BNP input is not auto focused in add rate page. #52810

Closed Krishna2323 closed 4 hours ago

Krishna2323 commented 5 days ago

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/51543 PROPOSAL: https://github.com/Expensify/App/issues/51543#issuecomment-2440232089

Tests

  1. Go to workspace settings > Taxes
  2. Tap Add rate
  3. Tap Value
  4. Verify the input is focused

Offline tests

  1. Go to workspace settings > Taxes
  2. Tap Add rate
  3. Tap Value
  4. Verify the input is focused

QA Steps

  1. Go to workspace settings > Taxes
  2. Tap Add rate
  3. Tap Value
  4. Verify the input is focused

// TODO: These must be filled out, or the issue title must include "[No QA]."

PR Author Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/7ac75e63-ea4b-431b-95cb-2d88adcbb04f
Android: mWeb Chrome https://github.com/user-attachments/assets/9170ebab-87e2-4cdf-8a2e-e79ffdcd5749
iOS: Native https://github.com/user-attachments/assets/b418e696-f704-4184-8768-ac1d8d47efa4
iOS: mWeb Safari https://github.com/user-attachments/assets/d881a11f-7ea6-4cbd-b402-6fa15631ea7f
MacOS: Chrome / Safari https://github.com/user-attachments/assets/d2a9afe1-7169-47e2-a7cb-6cf8e1e223d8
MacOS: Desktop https://github.com/user-attachments/assets/a0a8208f-6291-4d99-b410-a9c2a3ae728f
melvin-bot[bot] commented 5 days ago

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ollyws commented 9 hours ago

Reviewer Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/ec175529-ea88-4fc3-a6fc-a6d91e5ecd7f
Android: mWeb Chrome https://github.com/user-attachments/assets/a82e70a0-da11-4846-981d-f1a1d52fcfcf
iOS: Native https://github.com/user-attachments/assets/7fdc3b36-98b6-408c-9a60-f8d94d3e7620
iOS: mWeb Safari https://github.com/user-attachments/assets/01d9cab7-b9da-4a1e-8018-8bea0cca4664
MacOS: Chrome / Safari https://github.com/user-attachments/assets/a08d0277-fdfe-4862-89cd-ab729108358f
MacOS: Desktop https://github.com/user-attachments/assets/3b865892-2484-4e32-a8a9-d89013880b24
OSBotify commented 4 hours ago

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.