Open huult opened 2 days ago
@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@getusha I am checking the reason for the unit test failure.
@getusha I added a check for the test environment to skip this code because it doesn't need to be executed during testing. Without this check, the tests would fail since the test data wouldn't be added due to the lack of a session. Can you review it? Let me know if you have any questions.
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/48427 PROPOSAL: https://github.com/Expensify/App/issues/48427#issuecomment-2409091556
Tests
Same QA step
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/user-attachments/assets/0471fb75-e316-47a8-83b4-c34dbfc07fb3Android: mWeb Chrome
https://github.com/user-attachments/assets/fd378c1a-f2cb-4700-94ea-ce1be77f889biOS: Native
https://github.com/user-attachments/assets/704036cf-1808-4ce9-8bae-085e024306ddiOS: mWeb Safari
https://github.com/user-attachments/assets/4884fde4-d19b-4d2e-83e7-cf9ac27ff7e6MacOS: Chrome / Safari
https://github.com/user-attachments/assets/ce1d604d-fbe4-4da8-93df-1b19fbbb55f3MacOS: Desktop
https://github.com/user-attachments/assets/ad74f23c-a9dd-4867-aa3d-1c00e7f57025