Closed jnowakow closed 1 day ago
@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
Name | Duration |
---|---|
Linking | 781.753 ms β 1098.965 ms (+317.212 ms, +40.6%) π΄π΄ |
@Expensify/mobile-deployers π£ Please look into this performance regression as it's a deploy blocker.
This is a large change and I'm going to keep their blocker until we discuss.
My first thought is that these changes lead to OpenApp being called less frequently. Could this be because we're now importing NativeModules
in order to make the conditional check?
Explanation of Change
The problem was caused by
openApp
being called each time ND was opened in hybrid app. It downloads all information needed to open app for the first time. On subsequent start ups Onyx is filled with the data soreconnectApp
should be called.Fixed Issues
$ https://github.com/Expensify/App/issues/49964 PROPOSAL: N/A
Tests
Have a long chat with User B
As User A, access the chat on your device so itβs cached and kill the app
As User B, message User A
As User A, tap on the notification for the message.
Observe that there are no loading skeletons for previous messages
[x] Verify that no errors appear in the JS console
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
N/AAndroid: mWeb Chrome
N/AiOS: Native
N/AiOS: mWeb Safari
N/AMacOS: Chrome / Safari
N/AMacOS: Desktop
N/A