search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

Workspace chats are pinned in LHN for archived workspace #52835

Open m-natarajan opened 1 day ago

m-natarajan commented 1 day ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @flodnv Slack conversation (hyperlinked to channel name): ts_external_expensify_migrate

Action Performed:

  1. Login as a expelled member of workspace
  2. Observe LHN

Expected Result:

we should be:

Actual Result:

We aren't archiving the workspace chat (which should unpin it)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

melvin-bot[bot] commented 1 day ago

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

MelvinBot commented 1 day ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

flodnv commented 1 day ago

I think this is part of the #migrate project, right @puneetlath ?

garrettmknight commented 22 hours ago

OP updated, I'm betting this is internal.

puneetlath commented 20 hours ago

To be clear I think this is an issue with the MigratePolicies historical report migration. This is a workspace that Florent is no longer a member of. So in theory the workspace chat should be archived and unpinned. But it is not showing as archived or unpinned. So whoever looks into this should look into why that migration isn't archiving the workspace chat for people who are no longer a member of the migrated policy.

FYI @flaviadefaria I made it a hot pick.