[$250] Add header description to Concierge chat

dubielzyk-expensify commented 1 day ago

Problem

We've had multiple instance in our testing of people not knowing what Concierge is. Some think it's related to AI in some way. This causes them to miss out on one of the best features of Expensify.

Solution

Add a small description in the header of the Concierge chat like we do on Self DM:

cc @Expensify/design @jamesdeanexpensify

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021859701770005360001
Upwork Job ID: 1859701770005360001
Last Price Increase: 2024-11-21

Issue Owner

Current Issue Owner: @fedirjh

twilight2294 commented 1 day ago

Edited by proposal-police: This proposal was edited at 2024-11-21 07:50:42 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add header description to Concierge chat

What is the root cause of that problem?

Improvement

What changes do you think we should make in order to solve the problem?

First we need to update getChatRoomSubtitle : https://github.com/Expensify/App/blob/72034f21a698c9eb4c2d1d7a3ddb64b951e13808/src/libs/ReportUtils.ts#L4107

We need to check if isConciergeChatReport(report) is true and if so we need to show the text 24/7 support:

Then we also need to update getReportOption: https://github.com/Expensify/App/blob/72034f21a698c9eb4c2d1d7a3ddb64b951e13808/src/libs/OptionsListUtils.ts#L759

Here to we need to check if option.isConciergeChat is true and then set the alternateText to 24/7 support:

NotSo we need to update it with newly provided copy (same update for spanish copy as well)

What alternative solutions did you explore? (Optional)

twilight2294 commented 1 day ago

@dubielzyk-expensify what is the new header description ? the image is not loading in the issue description

Krishna2323 commented 1 day ago

Edited by proposal-police: This proposal was edited at 2024-11-20 23:27:48 UTC.

Proposal 

Please re-state the problem that we are trying to solve in this issue.

Add header description to Concierge chat

What is the root cause of that problem?

Improvement

What changes do you think we should make in order to solve the problem? 

We can update getWelcomeMessage to return new phrase if isConciergeChatReport is true. Similar to ReportUtils.isSystemChat(report) & ReportUtils.isSelfDM(report). https://github.com/Expensify/App/blob/d49d52dd3d9b3688c52a9fbbc93e988c826d209f/src/libs/SidebarUtils.ts#L559-L570
And the we can add || ReportUtils.isConciergeChatReport(report) in the condition below. https://github.com/Expensify/App/blob/d49d52dd3d9b3688c52a9fbbc93e988c826d209f/src/components/ReportWelcomeText.tsx#L42
Then we will render the welcomeMessage.phrase1 when ReportUtils.isConciergeChatReport(report) is true. Just like we have for isSelfDM && isSystemChat.
```
            {ReportUtils.isConciergeChatReport(report) && (
                <Text>
                    <Text>{welcomeMessage.phrase1}</Text>
                </Text>
            )}
```
What alternative solutions did you explore? (Optional)

We can return welcomeMessage.phrase2 when ReportUtils.isConciergeChatReport(report) is true. Add phrase 2 after this line.

if (ReportUtils.isConciergeChatReport(report)) {
    welcomeMessage.phrase2 = ' Some text to clarify what Concierge is for';
}

Render the welcomeMessage.phrase2 text after the {displayNamesWithTooltips.map(({displayName, accountID}, index) => ( text when ReportUtils.isConciergeChatReport(report) is true after this line.

Result

dubielzyk-expensify commented 1 day ago

what is the new header description ? the image is not loading in the issue description

Uploaded a new image, but the description says "24/7 support"

melvin-bot[bot] commented 1 day ago

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

mkzie2 commented 1 day ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add header description to Concierge chat

What is the root cause of that problem?

We don't have a special case for concierge chat, then it returns empty string here

https://github.com/Expensify/App/blob/8c8f8e353c15243ff9cde9a2dc664984bd6fb8b8/src/libs/ReportUtils.ts#L4117-L4119

What changes do you think we should make in order to solve the problem?

Create a new translation key for 24/7 support
Add a case for concierge chat before this line

if (isConciergeChatReport(report)) {
    return Localize.translateLocal('common.conciergeSupport'); // new translation key here
}

https://github.com/Expensify/App/blob/8c8f8e353c15243ff9cde9a2dc664984bd6fb8b8/src/libs/ReportUtils.ts#L4117-L4119

OPTIONAL: we can add option.alternateText for the concierge chat report here

https://github.com/Expensify/App/blob/8c8f8e353c15243ff9cde9a2dc664984bd6fb8b8/src/libs/OptionsListUtils.ts#L775

What alternative solutions did you explore? (Optional)

twilight2294 commented 1 day ago

Updated proposal :

Cleanup and new expected results

Note that my proposal was updated before the above proposal (our time of edits is the same)