Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

fix: navigate to switcher when clicking back button after creating a workspace from switcher #52863

Open etCoderDysto opened 1 day ago

etCoderDysto commented 1 day ago

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/47603 PROPOSAL: https://github.com/Expensify/App/issues/47603#issuecomment-2294986203

Tests

  1. Sign up with a new user
  2. Click on workspace switcher
  3. Click on Get started button
  4. Click on back button
  5. Verify that user is navigated to Chose a workspace modal
    • [x] Verify that no errors appear in the JS console

Offline tests

Same as test steps

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  1. Sign up with a new user
  2. Click on workspace switcher
  3. Click on Get started button
  4. Click on back button
  5. Verify that user is navigated to Chose a workspace modal
    • [x] Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native https://github.com/user-attachments/assets/25d51ffd-7446-4f22-b85a-abdf20ed8c1e
Android: mWeb Chrome https://github.com/user-attachments/assets/489d75a1-b3e2-4a4a-b790-903816e7a791
iOS: Native https://github.com/user-attachments/assets/aa4d07ad-0308-4757-80b7-089cc3229039
iOS: mWeb Safari https://github.com/user-attachments/assets/9a7dd93d-9548-4bdc-bde8-20f3553ef955
MacOS: Chrome / Safari https://github.com/user-attachments/assets/7eedbce3-448d-4db7-9c24-75dc9101ff55
MacOS: Desktop https://github.com/user-attachments/assets/0c497db7-76f1-4ab9-8514-4175ddf8ab48
melvin-bot[bot] commented 1 day ago

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]