Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

fix: copilot with removed access can still edit profile details #52865

Open nkdengineer opened 1 day ago

nkdengineer commented 1 day ago

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/51678 PROPOSAL: https://github.com/Expensify/App/issues/51678#issuecomment-2445119450

Tests

  1. User A is a main account
  2. User B is a copilot with full copilot access
  3. As User A navigate to Settings > Security
  4. Remove Copilot access for User B
  5. As User B try to make some changes in profile section (Add display name, status..)
  6. Verify that: DelegateNoAccessModal is displayed and user B is returned to the main account
    • [x] Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

PR Author Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop