Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

Hybrid - Launch - App is reloaded everytime that it´s backgrounded and opened again. #52874

Open izarutskaya opened 1 day ago

izarutskaya commented 1 day ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.65-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

  1. Open the Expensify app.
  2. Open any chat.
  3. Background the app.
  4. Reopen the app.
  5. Verify that the app doesn´t load again and that you remain on the opened chat.
  6. Navigate to a different section. (For Example: Search)
  7. Background the app.
  8. Reopen the app.
  9. Verify that the app is not loaded again and that you remain on the opened section.

Expected Result:

App shouldn´t be reloaded everytime that is backgrounded and reloaded and the user should remain on the same chat or section that before it was backgrounded.

Actual Result:

The app is reloaded everytime that is backgrounded and reopened and the user returns to inbox instead of remaining on the opened chat or section.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/3d853be2-afcf-4127-8467-bcdccfe4c643

View all open jobs on GitHub

melvin-bot[bot] commented 1 day ago

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 day ago

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 day ago

💬 A slack conversation has been started in #expensify-open-source

github-actions[bot] commented 1 day ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
cristipaval commented 20 hours ago

Looking

cristipaval commented 19 hours ago

ok, I could reproduce with 9.0.65-1

cristipaval commented 19 hours ago

I wonder if this is the offending PR, @Julesssss @war-in

cristipaval commented 19 hours ago

I wonder if this is the offending PR, @Julesssss @war-in

if yes, then I think it doesn't make sense to block the NewDot deployment, given that it needs to be fixed in the OldApp repository.

cristipaval commented 18 hours ago

More context here. TLDR: It seems that the root cause is from the OldApp code, ~so it might not make sense to deploy the App deployment.~ But given that we also release HybridApp when we release New Expensify, this is a valid blocker.

cristipaval commented 13 hours ago

Ok, so the next step is to test the revert of what we think the offending PR is to confirm, and if so, consider whether we want to fix this or revert the PR.